Merge pull request #22 from mcollina/clear-outstanding-packets

Stop ingesting packets after the client has errored

lib/client.js

@@ -158,8 +158,12 @@ Client.prototype.close = function (done) {
     finish()
   }
 
+  this.parser.removeAllListeners('packet')
+  conn.removeAllListeners('readable')
+
   if (this._keepaliveTimer) {
     this._keepaliveTimer.clear()
+    this._keepaliveInterval = -1
     this._keepaliveTimer = null
   }
 

test/regr-21.js

@@ -0,0 +1,30 @@
+'use strict'
+
+var test = require('tape').test
+var helper = require('./helper')
+var setup = helper.setup
+var connect = helper.connect
+
+test('after an error, outstanding packets are discarded', function (t) {
+  t.plan(1)
+  var s = connect(setup(), {
+    keepalive: 1000
+  })
+  var packet = {
+    cmd: 'publish',
+    topic: 'hello',
+    payload: 'world'
+  }
+
+  s.broker.mq.on('hello', function (msg, cb) {
+    t.pass('first msg received')
+    s.inStream.emit('error', new Error('something went wrong'))
+    setImmediate(cb)
+  })
+
+  s.inStream.write(packet)
+  setImmediate(function () {
+    s.inStream.write(packet)
+    s.inStream.write(packet)
+  })
+})