Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced retain tests and refactored into test/retain.js #275

Merged
merged 1 commit into from
Jul 20, 2019
Merged

Enhanced retain tests and refactored into test/retain.js #275

merged 1 commit into from
Jul 20, 2019

Conversation

gnought
Copy link
Collaborator

@gnought gnought commented Jul 19, 2019

Added tests:

  • reconnected subscriber will not receive retained messages when QoS 0 and clean
  • new subscribers receive retained messages when QoS 0 and clean
  • clean retained messages
  • fail to clean retained messages without retain flag
  • only get the last retained messages in same topic

mcollina
mcollina approved these changes Jul 20, 2019
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 308edc2 into moscajs:master Jul 20, 2019
@gnought gnought deleted the feature/enhance_retain_tests branch July 20, 2019 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gnought @mcollina