Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize handle function #297

Merged
merged 5 commits into from
Aug 13, 2019
Merged

Optimize handle function #297

merged 5 commits into from
Aug 13, 2019

Conversation

gnought
Copy link
Collaborator

@gnought gnought commented Aug 11, 2019

No description provided.

mcollina
mcollina reviewed Aug 12, 2019
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please explain this a bit?

test/handlers/connect.js Outdated Show resolved Hide resolved
mcollina
mcollina reviewed Aug 13, 2019
View reviewed changes
test/handlers/connect.js Outdated Show resolved Hide resolved
mcollina
mcollina approved these changes Aug 13, 2019
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gnought gnought merged commit 992cce1 into moscajs:master Aug 13, 2019
@gnought gnought deleted the feature/optimize_handle_fn branch August 13, 2019 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gnought @mcollina