Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

max listeners independent of concurrency #89

Closed
wants to merge 1 commit into from

Conversation

GavinDmello
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented Feb 24, 2017

Coverage Status

Coverage remained the same at 97.26% when pulling 1d75e7b on GavinDmello:master into cf4e7ca on mcollina:master.

Copy link
Contributor

@cordovapolymer cordovapolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your fix doesn't make any sense since getMaxListeners returns default value of max listeners which is 10. So you set max listeners back to this value.
To achieve same behavior you could just comment out line 43.

Checked your proposal with test provided in Archive.zip in #88 (comment), at a first glance it's a solution, but changing publishing interval from 50 to 10 msecs leads to aedesbroker.js hang, whilst moscabroker.js is still ok, even on 1 msec interval.

@GavinDmello
Copy link
Collaborator Author

GavinDmello commented Mar 2, 2017

Why doesn't it make sense ? As I've mentioned the issue is not the listeners.
What point it does it hang ?
I'm able to publish 20,000+ messages without any hanging with the same script .
Could you upload your test/ hanging script ?

@GavinDmello GavinDmello closed this Mar 2, 2017
@cordovapolymer
Copy link
Contributor

@GavinDmello the archive.zip in #88 .
It doesn't make sense since it's 10 by default https://nodejs.org/api/events.html#events_eventemitter_defaultmaxlisteners . And you set it back to the default value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants