allow set server id for keep server id when restart #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
|
I'm a bit lost on why this will fix a will topic problem. Maybe we need to fix the will topic problem differently. Anyhow, would you mind to add a unit test? |
|
Maybe while streaming the wills we can replace the brokerId with the current broker Id ? |
|
@GavinDmello yes! that's better, and it fixes the problem for every persistence. |
|
@nguyenthenguyen You can include that in your PR then |
|
I'm just try aedes, I don't know how to fix this better. @GavinDmello Could you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
aedes-persistence-redisand server restart, new server id generated, will topic has retain with old server id, server startheartbeatwill publish will topic to client by https://github.com/mcollina/aedes/blob/master/aedes.js#L94