Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colors disabled when -j is set and we are writing to a file #59

Closed
mcollina opened this issue Jul 11, 2016 · 2 comments
Closed

colors disabled when -j is set and we are writing to a file #59

mcollina opened this issue Jul 11, 2016 · 2 comments

Comments

@mcollina
Copy link
Owner

As titled, we might probably want to override some stuff in chalk.

Chalk is disabled because of a check in https://github.com/chalk/supports-color/blob/master/index.js.

See https://github.com/chalk/supports-color/blob/master/index.js#L41-L43.

We can either internalize that check, or sending them a PR to expose that as a function that accepts a stream. Or maybe it's just a new module.

@GlenTiki
Copy link
Collaborator

I think that a pr is the best approach. Will do later 👍

@mcollina
Copy link
Owner Author

See also https://github.com/isaacs/color-support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants