Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in stream not surfaced correctly #18

Closed
phated opened this issue May 16, 2019 · 1 comment · Fixed by #19
Closed

Error in stream not surfaced correctly #18

phated opened this issue May 16, 2019 · 1 comment · Fixed by #19

Comments

@phated
Copy link

phated commented May 16, 2019

Hey @mcollina! I've been working with this a bunch recently and I think I ran into an issue where an error in the Readable stream wrapped by this module won't be surfaced correctly to something like stream.pipeline().

I've created a reproduction at https://github.com/phated/cloneable-readable-error-bug - would you have some time to point me in the right direction on this?

@mcollina
Copy link
Owner

I have no clue! I’ll look into this as soon as I get the chance.

As for tip into debugging things, I’ll try to reproduce without the from2 module, just to remove one piece of the puzzle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants