Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relies (transitively) on vulnerable version of inflight #17

Closed
thetumper opened this issue Dec 1, 2023 · 5 comments · Fixed by #19
Closed

Relies (transitively) on vulnerable version of inflight #17

thetumper opened this issue Dec 1, 2023 · 5 comments · Fixed by #19

Comments

@thetumper
Copy link

Seems that inflight is not expected to be fixed (see this comment). So, the upstream libs using it should fix by updating to later versions of the in between dependency (glob).

For my app, the dependency chain starts with pino-pretty, but this help-me lib would be the point of upgrading to newer version of glob to resolve:

pino-pretty@10.2.3 › help-me@4.2.0 › glob@8.1.0 › inflight@1.0.6

The Snyk issue, for reference:
https://security.snyk.io/vuln/SNYK-JS-INFLIGHT-6095116

@mcollina
Copy link
Owner

mcollina commented Dec 2, 2023

Would you like to send a PR to address this issue?

@thetumper
Copy link
Author

Added a PR:

#18

One unit test is skipped temporarily, until I have time to figure out what's going wrong....

@thetumper
Copy link
Author

Added a PR:

#18

One unit test is skipped temporarily, until I have time to figure out what's going wrong....

Resolved the unit test. @mcollina Please have a look. Thanks!

@rreeves8
Copy link

Can we get this merged ? Needed for Pino fix

@mcollina
Copy link
Owner

unit tests are still not passing. Will take a look asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants