This repository has been archived by the owner on Feb 11, 2020. It is now read-only.
V1 dev #396
Merged
V1 dev #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added ascoltatori-2.0.0pre1 as a dependency - bumped almost all other dependencies - minor changes needed for new version of `memdown` packet - locally building and passing on node 4, thumbs down!
Ascoltatori does not support iojs v3
|
Cool! I'm just a bit unsure about iojsv3. I removed it yesterday mainly because it was not in ascoltatori and because I had a test failure which later turned out to be that race condition. It's possible that we could take it back in both for ascoltatori and mosca. On the other hand I figure most people who had switched to iojs are now on node4.. |
|
lol.. I have to train: first read, then write.. just realized that you took out iojs completely |
|
Yeah, I'm not targeting iojs at all. If you are on iojs, switch to Node 4 or Node 5. |
|
leave me a note as soon as you have published, I'll update ascoltatori then. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please test, I'm bumping the major because we are soft-deprecating v0.10, meaning that it should work fine on 0.10, but you should update (and some adapeters, mainly 'filesystem' will not work).
I'll be publishing this as 1.0.0-pre1 shortly on NPM.
cc @behrad @psorowka