Skip to content
This repository has been archived by the owner on Feb 11, 2020. It is now read-only.

V0.14.3 wip #77

Merged
merged 15 commits into from Dec 11, 2013
Merged

V0.14.3 wip #77

merged 15 commits into from Dec 11, 2013

Conversation

mcollina
Copy link
Collaborator

This contains the fix by @ldstein plus some fix due to conflicts in package.json.

@ldstein, can you confirm this $ npm install in windows? I've updated async_bench to use the windows-compatible version of microtime.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling ad6b546 on v0.14.3-wip into 3343b1d on master.

@ldstein
Copy link
Contributor

ldstein commented Dec 11, 2013

Looks good. NPM can install on both Win and Ubuntu. 448 unit tests all passed without errors.

There is still a lingering issue regarding Async_bench and Windows compatibility. Async_bench has a dependency on Atoll.js. Atoll runs a Makefile on install which isn't Windows friendly. The MakeFile itself simply minifies the lib via uglify.js. It's not a showstopper on Windows - as it doesn't seem to be used either by Mosca in production or the unit tests (benchmarking I assume?).

@ldstein
Copy link
Contributor

ldstein commented Dec 11, 2013

I've posted a request to @nsfmc to change the build step in Atoll to be part of the NPM Package release process.

@nsfmc
Copy link

nsfmc commented Dec 11, 2013

thanks @ldstein for your comprehensive issue report. i'll try to take care of this soon. sorry for the inconvenience.

@ldstein
Copy link
Contributor

ldstein commented Dec 11, 2013

Many thanks @nsfmc, confirmed Atoll now installing nicely on Windows!

@mcollina : If you can bump Async_bench's Atoll dep to ~0.7.4 that will solve the final Window install issue.

@mcollina
Copy link
Collaborator Author

It depends on ~v0.7.3, so it should be already working. I'll merge and release later.

@ldstein
Copy link
Contributor

ldstein commented Dec 11, 2013

Good point. Just tried reinstalling and everything is working nicely.

mcollina added a commit that referenced this pull request Dec 11, 2013
@mcollina mcollina merged commit 9d4ce43 into master Dec 11, 2013
@mcollina mcollina deleted the v0.14.3-wip branch December 11, 2013 09:21
@mcollina
Copy link
Collaborator Author

Released as 0.14.3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants