Handle NaN #75
Merged
Handle NaN #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
reviewed
Sep 17, 2018
test/15-elements-maps.js
Outdated
| var toEncode = { a: NaN, hello: 'world' } | ||
| var buf = instance.encode(toEncode) | ||
|
|
||
| t.deepEqual(expected, instance.decode(buf), 'must ignore NaN') |
There was a problem hiding this comment.
why? Shouldn't it have the same behavior as encoded directly?
There was a problem hiding this comment.
did it same as for undefined value
There was a problem hiding this comment.
They are different. The behavior of undefined is matching how JSON.stringify() works. undefined in javascript means "there is nothing here". NaN has a different meaning altogether. It should throw anyway.
There was a problem hiding this comment.
Ok, will remove that
This was referenced Mar 12, 2021
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 12, 2021
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #74.