Fix LRU cache bloat #136
Fix LRU cache bloat #136
Conversation
| // Start timer to actively prune from LRU cache after expiration | ||
| buf.lru_timer = setTimeout(function () { | ||
| lru.get(key); | ||
| }, that._lruMaxAge + 1000) |
There was a problem hiding this comment.
you can create an interval and call unref(), then you won't need to reset the timer every time.
There was a problem hiding this comment.
Indeed, this can go given the change above.
I was being careful with unref() as the CI script didn't like it on the older node versions.
| , length: function(n) { return n.length } | ||
| , maxAge: parameters.exchangeLifetime | ||
| , length: function(n) { return n.buffer.byteLength } | ||
| , maxAge: this._lruMaxAge |
There was a problem hiding this comment.
there is no need to make _lruMaxAge a property, assign it directly here.
There was a problem hiding this comment.
OK. I'll switch to an Interval called once every maxAge that runs a prune() across the whole lru.
|
Also, do you have some ideas into adding a unit test for this? |
| // Start LRU pruning timer | ||
| this._lru.pruneTimer = setInterval(function () { | ||
| that._lru.prune() | ||
| }, parameters.pruneTimerPeriod*1000) |
There was a problem hiding this comment.
can you please unref() this?
There was a problem hiding this comment.
this is still not unref().
There was a problem hiding this comment.
it is below - one of the mock timer libraries doesn't support unref() so I had to put a guard around it.
|
Please ignore the PR for the time being - I'm having trouble getting the tests to run reliably on both Windows & Linux |
|
OK. Working well on Linux, although Travis CI is failing for node 0.12. Do you think that's something I've done or due to a changing dependency? |
|
I'm ok in dropping support for node v0.12. Would you like to help maintaining/developing this module? |
|
Sorry to disappear - I went off sick for the second half of last week, and I've been catching up ever since. Time is short for me at the moment, but I'm happy to help the maintenance effort when I can. |
See #135.