[depends on nullsafety] Friction fix revived #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implement AnimationPadding
mcrovero
reviewed
Mar 27, 2021
There was a problem hiding this comment.
Really like the approach with the Animation Padding.
Just one thing, while testing on the iOS simulator, I noticed that in the .bottomOnly() (old default) the drag is behaving unexpectedly if the drag gesture goes above the top end of the bottomsheet. Probably the bug was already present before the change as I don't remember testing it in a similar scenario. What do you think?
|
@mcrovero you're right – turns out my friction fix wasn't adequate. The issue wasn't just that friction should be divided by, but also that it should be |
mcrovero
approved these changes
Apr 8, 2021
|
published as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #53
This is pretty much the same change as #54, except that:
AnimationPadding.none()withAnimationPadding.bottomOnly()because that is actually what the old default behavior was, getting rid of the easy fling offscreen issue