Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage CppNode and CppEdge entities on incremental parsing #2

Closed
mcserep opened this issue Jun 21, 2018 · 1 comment
Closed

Manage CppNode and CppEdge entities on incremental parsing #2

mcserep opened this issue Jun 21, 2018 · 1 comment
Assignees
Labels
Kind: Enhancement New feature or request Target: Incremental parsing Towards incremental parsing

Comments

@mcserep
Copy link
Owner

mcserep commented Jun 21, 2018

During incremental parsing CppNode and CppEdge entities should also be managed, deleting invalidated entries related to be deleted File and CppAstNode entries.
Note that on parse new CppNode and CppEdge entities are created not only for the parsed file, thus more thorough deletion or refactoring might be required.

@mcserep mcserep added the Target: Incremental parsing Towards incremental parsing label Jun 21, 2018
@mcserep mcserep self-assigned this Jun 21, 2018
@mcserep mcserep changed the title Manage CppNode and CppEdge entities on incremental parsing Manage CppNode and CppEdge entities on incremental parsing Jun 21, 2018
@mcserep
Copy link
Owner Author

mcserep commented Jul 4, 2018

Solved in ccb943b and 09d2685.

Note that some warnings on incremental parsing will remain, complaining about already persisted CppNode and CppEdge entities. This issue should be automatically solved by making the domainId of the CppNode strongly typed (uint64_t instead of string) and removing directory level relations (DEPENDS and PROVIDES), which should be calculated on-demand, runtime. These alterations of the CppNode and CppEdge entities were decided on the Ericsson CodeCompass meeting on the 4th of July, but are not tightly related to the incremental parsing itself and a separate pull request should be made to the main repository.

@mcserep mcserep closed this as completed Jul 4, 2018
@mcserep mcserep mentioned this issue Jul 16, 2018
5 tasks
@mcserep mcserep added the Kind: Enhancement New feature or request label Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kind: Enhancement New feature or request Target: Incremental parsing Towards incremental parsing
Projects
None yet
Development

No branches or pull requests

1 participant