Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backward McTorch is not working #7

Open
Agathon-geo opened this issue Aug 22, 2019 · 3 comments
Open

Backward McTorch is not working #7

Agathon-geo opened this issue Aug 22, 2019 · 3 comments

Comments

@Agathon-geo
Copy link

Agathon-geo commented Aug 22, 2019

Hi @mayank127 and @thegodone
Let me first thank you for your work.
I followed your instruction to install mctorch as follow :

conda create -n myenv python=3.5.6
source activate myenv
git clone --recursive https://github.com/mctorch/mctorch # mctorch_1_1
cd mctorch
python setup.py install

My torch version is 1.1.0 and torch.version.cuda '8.0.44'

The forward pass works but the backward pass fails. Here is the error :

p.data.add_(p.manifold.retr(p.data, -clr * modified_rgrad)
 File "~/torch/nn/manifolds/stiefel.py", line
72, in retr
   q, r = torch.qr(X + G)
RuntimeError: No CUDA implementation of 'qr'. Install MAGMA and rebuild cutorch (http://icl.cs.utk.edu/magma/) at
~/mctorch/aten/src/THC/generic/THCTensorMathMagma.cu:613

Here is my forward pass where it get stuck :

self.Stiefel = nn.Parameter(manifold=nn.Stiefel(28, 6))
 self.Euclidian = nn.Parameter(manifold=nn.Euclidean(6, 28))
Te=self.Stiefel.mm(self.Euclidian)` # backward not working

Magma is installed along with conda install pytorch=x.x.x cudaYY -c pytorch

Thank you

@Agathon-geo
Copy link
Author

The same for pytorch1.2.0

@mayank127
Copy link
Contributor

Hey @Agathon-geo ,

Can you please try using McTorch in an environment where PyTorch is not installed? As it is a fork of PyTorch, everything PyTorch is already included in McTorch.

As for Euclidean can you try without any manifold parameter (None will use the default pytorch backward pass).

Let me know if these work for you.

@bamdevm
Copy link
Contributor

bamdevm commented Dec 20, 2019

Hello @Agathon-geo, does it help?

@mayank127, should we close the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants