Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: usb_free_async should check CloseHandle return value #12

Closed
mcuee opened this issue Jun 23, 2018 · 4 comments
Closed

Bug: usb_free_async should check CloseHandle return value #12

mcuee opened this issue Jun 23, 2018 · 4 comments
Labels

Comments

@mcuee
Copy link
Owner

mcuee commented Jun 23, 2018

https://sourceforge.net/p/libusb-win32/patches/14/

Updated: 2012-07-06 Created: 2012-01-30 Creator: Kirill Batuzov

I believe usb_free_async should check return value of CloseHandle. Otherwise a situation when CloseHandle fails for some reason and not actually closes handle but usb_context_t is being freed nevertheless is entirely possible. This would lead to a resource leak which is nearly impossible to diagnose from a user application.

@mcuee mcuee added the wontfix label Jun 23, 2018
@mcuee
Copy link
Owner Author

mcuee commented Jun 23, 2018

libusb-win32 project is in a support only mode. Mailing list support is still provided, no changes to the codes and release, unless critical bug found and the fixes are feasible.

@mcuee
Copy link
Owner Author

mcuee commented Oct 19, 2021

@dontech Not sure if this is still relevant or not. Please take a look. We can close it if it is no longer relevant.

@dontech
Copy link
Collaborator

dontech commented Oct 24, 2021

609c02d

@dontech
Copy link
Collaborator

dontech commented Oct 24, 2021

Fixed on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants