Optionally replace pipes for dots in auth0 username #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How do you handle the fact that pipes are an illegal character in Django usernames? |
|
I don't handle it, it just works. Django allow you to set by code a username with a pipe. |
mcueto
approved these changes
Apr 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the dot instead of the pipe, the usernames in my backend are inconsistent with the usernames in auth0, so if I need to change some user info in auth0 from my backend, I must replace again the dots for pipes.
This can be configurable with the settings var REPLACE_PIPE_FOR_DOTS_IN_USERNAME, which is True by default.