-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EntityInterface to FileEntity #26
Comments
Hm, yes, I just added the EntityInterface typehint to the method in fe3ebb8, making the test pass. FileEntity implements that interface but not directly. |
Then you should get an exception about FileEntity not implementing the EntityInterface in the tests. |
No errors about that on the travis-ci build, nevermind then: |
The fix looks fine. FileEntity can not not implement that interface, it extends from a class that does. It's more likely that the parent method there was changed and that broke it. That also means that the related core patches for bringing this into core need to be updated if they haven't been already. |
There is an exception about FileEntityNormalizer::getEntityUri($entity) not matching the parent class: ContentEntityNormalizer::getEntityUri(EntityInterface $entity)
Adding EntityInterface to the FileEntityNormalizer method isn't enough though, since FileEntity doesn't implement the EntityInterface yet.
The text was updated successfully, but these errors were encountered: