Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unittests fail because of localization settings #34

Closed
andjor opened this issue Oct 20, 2017 · 1 comment
Closed

Unittests fail because of localization settings #34

andjor opened this issue Oct 20, 2017 · 1 comment

Comments

@andjor
Copy link
Contributor

andjor commented Oct 20, 2017 •
edited

Some unittests compare against hardcoded strings written in the test method. These fail on systems that use ,(comma) as decimal separator instead of .(dot). These strings should probably be loaded from a resource or the entire library should work with invariant culture unless otherwise specified.
@mdabros mdabros mentioned this issue Feb 24, 2019
Merged
@mdabros
Copy link
Owner

mdabros commented Feb 24, 2019

@andjor This has finally been fixed in #103

@mdabros mdabros closed this as completed Feb 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mdabros @andjor