Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packet type is not always located in the first byte of packet's raw data #79

Closed
mdabrowski1990 opened this issue Sep 9, 2021 · 0 comments · Fixed by #102
Closed

Packet type is not always located in the first byte of packet's raw data #79

mdabrowski1990 opened this issue Sep 9, 2021 · 0 comments · Fixed by #102
Assignees
@mdabrowski1990
Labels
bug Something isn't working
Projects
UDS
Milestone
2) CAN tools

Comments

@mdabrowski1990
Copy link
Owner

mdabrowski1990 commented Sep 9, 2021 •
edited

Describe the bug
For some buses (e.g. LIN, or CAN with extended addressing), packet type information is located in the second byte of raw_data.
Function get_raw_packet_type is not always correct, therefore this peace of code requires minor rework.

To Reproduce

  1. Go to uds_packet.py
  2. Execute get_raw_packet_type for CAN with extended addressing
  3. See the result is not correct.

Expected behavior
Value of packet type can only be assessed when bus and its configuration is known (for example CAN with normal or extended addressing have different results)
@mdabrowski1990 mdabrowski1990 added the bug Something isn't working label Sep 9, 2021
@mdabrowski1990 mdabrowski1990 added this to New in UDS via automation Sep 9, 2021
This was referenced Sep 10, 2021
Closed
Closed
@mdabrowski1990 mdabrowski1990 moved this from New to Defined in UDS Sep 18, 2021
@mdabrowski1990 mdabrowski1990 self-assigned this Sep 19, 2021
@mdabrowski1990 mdabrowski1990 moved this from Defined to In progress in UDS Sep 19, 2021
@mdabrowski1990 mdabrowski1990 linked a pull request Sep 19, 2021 that will close this issue
Fix N_PCI is not assessed on first byte of raw_data #102
Merged
UDS automation moved this from In progress to Done Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdabrowski1990 mdabrowski1990

Labels
bug Something isn't working
Projects
No open projects
UDS
  
Done
Milestone
2) CAN tools
Development

Successfully merging a pull request may close this issue.

Fix N_PCI is not assessed on first byte of raw_data mdabrowski1990/uds
1 participant
@mdabrowski1990