CMakeLists.txt: only change RPATH when building for shared #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing static-only builds (-DJAS_ENABLE_SHARED=OFF) the install
process fails due to an invalid RPATH:
...............................................................
CMake Error at src/appl/cmake_install.cmake:45 (file):
file RPATH_CHANGE could not write new RPATH:
/usr/lib
to the file:
/br/output/host/usr/xtensa-buildroot-linux-uclibc/sysroot/usr/bin/jasper
No valid ELF RPATH or RUNPATH entry exists in the file;
Call Stack (most recent call first):
cmake_install.cmake:42 (include)
...............................................................
RPATH shouldn't be changed when doing static-only builds.
Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
|
Thanks for the fix. To try to catch possible problems with static vs. shared library builds in the future, I have modified the Travis CI test script to build and install for both the static and shared library cases. Perhaps, this would have caught the problem that you found prior to release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing static-only builds (-DJAS_ENABLE_SHARED=OFF) the install
process fails due to an invalid RPATH:
...............................................................
CMake Error at src/appl/cmake_install.cmake:45 (file):
file RPATH_CHANGE could not write new RPATH:
to the file:
No valid ELF RPATH or RUNPATH entry exists in the file;
Call Stack (most recent call first):
cmake_install.cmake:42 (include)
...............................................................
RPATH shouldn't be changed when doing static-only builds.
Signed-off-by: Vicente Olivert Riera Vincent.Riera@imgtec.com