Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿƒโ€โ™€๏ธClean up the fastlane code #14

Merged
merged 1 commit into from
Aug 31, 2021

Conversation

mdb1
Copy link
Owner

@mdb1 mdb1 commented Aug 31, 2021

๐Ÿ‘‹ Intro

The current fastlane code to run on github actions have a couple of hacks to bring up the simulator early. This should no longer be needed.

๐Ÿค” What changed?

  • Deleted the hacks to bring up the simulator that are no longer needed
  • Cleaned up the lanes to run the regional tests
  • Updated the documentation

โœ… Checklist

  • Documentation on how to cherry-pick to another project added in Documentation/
  • README updated

* Delete the hacks to bring up the simulator that are no longer needed
* Clean up the lanes to run the regional tests
* Update the documentation
@mdb1 mdb1 added the enhancement Improvements to the existing code label Aug 31, 2021
@mdb1 mdb1 self-assigned this Aug 31, 2021
@mdb-danger-bot
Copy link

Warnings
โš ๏ธ PR does not contain any files related to unit tests โœ… (ignore if your changes do not require tests)
Messages
๐Ÿ“– ๐ŸŽ‰ The PR added 22 and removed 70 lines. ๐Ÿ—‚ 5 files changed.

Generated by ๐Ÿšซ Danger Swift against 2ebe218

@mdb1 mdb1 merged commit 29ef18f into main Aug 31, 2021
@mdb1 mdb1 deleted the ci/clean_fastlane branch August 31, 2021 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to the existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants