Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable more SwiftLint Rules #17

Merged
merged 2 commits into from
Sep 2, 2021
Merged

Enable more SwiftLint Rules #17

merged 2 commits into from
Sep 2, 2021

Conversation

mdb1
Copy link
Owner

@mdb1 mdb1 commented Sep 2, 2021

πŸ‘‹ Intro

Add more SwiftLint rules to the project

πŸ€” What changed?

  • Enabled the following rules:
- attributes
- duplicate_imports
- missing_docs
- single_test_class
- sorted_imports
- test_case_accessibility
- vertical_parameter_alignment_on_call
- vertical_whitespace_closing_braces
- vertical_whitespace_opening_braces
- xct_specific_matcher
  • Fix the new warnings
  • Removed redundant 'inthibit_warnings' from SwiftGet pod

βœ… Checklist

  • Documentation on how to cherry-pick to another project updated in Documentation/

Rules added:
- attributes
- duplicate_imports
- missing_docs
- single_test_class
- sorted_imports
- test_case_accessibility
- vertical_parameter_alignment_on_call
- vertical_whitespace_closing_braces
- vertical_whitespace_opening_braces
- xct_specific_matcher
@mdb1 mdb1 added the enhancement Improvements to the existing code label Sep 2, 2021
@mdb1 mdb1 self-assigned this Sep 2, 2021
@mdb-danger-bot
Copy link

Messages
πŸ“– πŸŽ‰ The PR added 30 and removed 28 lines. πŸ—‚ 15 files changed.

Generated by 🚫 Danger Swift against cc16098

@mdb1 mdb1 merged commit dd7dc26 into main Sep 2, 2021
@mdb1 mdb1 deleted the enhancements/swifttlint-rules branch September 2, 2021 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to the existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants