Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MVP - UI Design Pattern #20

Merged
merged 5 commits into from
Sep 10, 2021
Merged

MVP - UI Design Pattern #20

merged 5 commits into from
Sep 10, 2021

Conversation

mdb1
Copy link
Owner

@mdb1 mdb1 commented Sep 9, 2021 •
edited

👋 Intro

Add the basics for having the MVP design pattern in the app

🤔 What changed?

  • 🎨 Added initial MVP skeleton
  • Added BaseViewController, MainViewController, and FeaturesViewController
  • Added their views and presenters
  • Renamed ViewController to ColorPaletteViewController and adapt it to MVP
  • 🧪 Added unit tests for the new additions
  • ✂️ Remove the post-build script due to problems with Xcode generating test reports
  • 🐛 Minor change in hexString() method for UIColor
  • 🧪 Added a playground with the sample code from the docs

🍒 How to cherry-pick to another project

Read the docs on Documentation/MVP.md

✅ Checklist

  • Documentation on how to cherry-pick to another project added in Documentation/MVP.md
  • README updated
  • Tests added for the new additions

📱 Screenshots

Features List ColorPalette

@mdb1 mdb1 added the enhancement Improvements to the existing code label Sep 9, 2021
@mdb1 mdb1 self-assigned this Sep 9, 2021
@mdb1 mdb1 added the don't merge The PR is not ready to be merged label Sep 9, 2021
@mdb-danger-bot
Copy link

mdb-danger-bot commented Sep 9, 2021 •
edited

Warnings
⚠️ PR size seems relatively large. ✂️ If this PR contains multiple changes, please split each into separate PR will helps faster, easier review.
Messages
📖 🎉 The PR added 1205 and removed 50 lines. 🗂 29 files changed.

Generated by 🚫 Danger Swift against 550bb5a

@mdb1
🎨 Add initial MVP skeleton
0afcdbe 
✅ Add BaseViewController
✅ Add BaseView
✅ Add BasePresenter and Presentable protocol
✅ Rename ViewController to ColorPaletteViewController and adapt it to MVP
@mdb1
🧪 Add unit tests for BaseView and ColorPaletteScreen
485733a 
✂️ Remove the post-build script due to problems with Xcode generating test reports
🐛 Minor change in hexString() method for UIColor
@mdb1 mdb1 force-pushed the feature/mvp-design-pattern branch 2 times, most recently from 70c41c7 to 9336730 Compare September 9, 2021 21:17
@mdb1
🎨 Add Main VC as UITabBarController
51c6c69 
✅ Add it's Presenter
✅ Rename the getCurrentPalette methods in the protocols
@mdb1
🎨 Add Features Screen with presenter
32feab4 
🧪 Add unit tests to the features screen
🧪 Add mocked unit test to the color palette screen
@mdb1 mdb1 force-pushed the feature/mvp-design-pattern branch 2 times, most recently from 8048196 to a7321bd Compare September 10, 2021 02:43
@mdb1 mdb1 removed the don't merge The PR is not ready to be merged label Sep 10, 2021
@mdb1
📝 Add docs for MVP
550bb5a 
* Also update the TODO's order in the Readme
* Add playground with the sample code and tests
@mdb1 mdb1 merged commit 16f72ca into main Sep 10, 2021
@mdb1 mdb1 deleted the feature/mvp-design-pattern branch September 10, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mdb1 mdb1

Labels
enhancement Improvements to the existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mdb1 @mdb-danger-bot