Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minimum documentation level to internal #21

Merged
merged 2 commits into from
Sep 18, 2021
Merged

Conversation

mdb1
Copy link
Owner

@mdb1 mdb1 commented Sep 18, 2021

👋 Intro

Add swiftlint warning when something internal is not documented, in order to keep a high percentage of the codebase documented

🤔 What changed?

  • Configured missing_docs rule to display warnings for internal things and errors for open and public
  • Changed generate_docs script to use internal as minimum documentation level in jazzy
  • Added missing documentation in the codebase
  • Ran generate_docs script

@mdb1 mdb1 added the documentation Improvements or additions to documentation label Sep 18, 2021
@mdb1 mdb1 self-assigned this Sep 18, 2021
@mdb-danger-bot
Copy link

Warnings
⚠️ PR size seems relatively large. ✂️ If this PR contains multiple changes, please split each into separate PR will helps faster, easier review.
Messages
📖 🎉 The PR added 26336 and removed 98 lines. 🗂 110 files changed.

Generated by 🚫 Danger Swift against aa4f373

@mdb1 mdb1 merged commit 9e8ffe0 into main Sep 18, 2021
@mdb1 mdb1 deleted the docs/document_internal branch September 18, 2021 15:47
@mdb1 mdb1 changed the title Set minimum documentation to internal Set minimum documentation level to internal Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants