Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for event "open" and "close" #40

Closed
giacomarco opened this issue Apr 22, 2022 · 6 comments
Closed

Request for event "open" and "close" #40

giacomarco opened this issue Apr 22, 2022 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@giacomarco
Copy link

giacomarco commented Apr 22, 2022

Sorry for my english.

Thank you for your work and it's a wonderful project.

If you can i need more events for example "open" and "close"

change event not trigger on close if there's no change color.
In local i add currentEl.dispatchEvent(new Event('close', { bubbles: true })); on line 290
and currentEl.dispatchEvent(new Event('open', { bubbles: true })); on line 184

Thank you so much , Marco

@jepsar
Copy link
Contributor

jepsar commented Apr 22, 2022

Won't the focus and change events on the input do?

@giacomarco
Copy link
Author

giacomarco commented Apr 22, 2022

no because i'm not using input as "trigger" but a button with value. Thank you for your fast reply @jepsar

@mdbassit
Copy link
Owner

While I don't agree with not using an input field as a trigger, I don't see any harm in adding an open and close events. I'll push an update later today.

@mdbassit mdbassit self-assigned this Apr 22, 2022
@mdbassit mdbassit added the enhancement New feature or request label Apr 22, 2022
@giacomarco
Copy link
Author

thank you so much, i agree with you that's better to use with input field as trigger but i use in a richeditor and I must to uniform the style of buttons. Thank you @mdbassit for your supports

@melloware
Copy link
Contributor

This is now available on NPM as v 0.11.0 : https://www.npmjs.com/package/@melloware/coloris

Excellent work @mdbassit

@mdbassit
Copy link
Owner

Thank you @melloware for your help with the NPM package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants