New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fluid modal long content overflow issue #44
Comments
Hello pavillet, on which browser did you encountered this case? |
Hello, Chrome Version 63.0.3239.132 (Build officiel) (64 bits) I just tested and I'm still seeing the issue on the docs Thanks |
It is on your documentation so the code is the "real" one :)
Did you try reducing the window height ?
Thanks
2018-01-18 11:18 GMT+01:00 Bloodcast69 <notifications@github.com>:
… [image: safari]
<https://user-images.githubusercontent.com/25751236/35092930-25f4ff32-fc41-11e7-9883-2e2af54b7fd9.png>
[image: chrome]
<https://user-images.githubusercontent.com/25751236/35092938-29064294-fc41-11e7-8975-adc9fadba8c6.png>
I've tested it on MacOs 10.12.6. Did you copied right code from our
documentation?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#44 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AV0ynHMxf1R3B5dV09hZaYamZXzCooXyks5tLxqEgaJpZM4RekYH>
.
--
Adrien PAVILLETCO FONDATEUR+33 6 24 60 28 70
adrien@wertkt.com
https://wertkt.com
|
Yes, i've tried to reduce window height in responsive view, and it's worked correctly. |
<img width="1425" alt="capture d ecran 2018-01-18 a 11 24 29" src="https://user-images.githubusercontent.com/22885020/35093302-5705243e-fc42-11e7-9324-0b435f17a3df.png">
<img width="1436" alt="capture d ecran 2018-01-18 a 11 24 20" src="https://user-images.githubusercontent.com/22885020/35093304-57238b36-fc42-11e7-8b3e-73409a752fe1.png">
I'm on https://mdbootstrap.com/angular/advanced/modals/ so the version you
use for the docs
To show you I have 2 screenshots, one will full height one where I reduce
the height
2018-01-18 11:21 GMT+01:00 Bloodcast69 <notifications@github.com>:
… Yes, i've tried to reduce window height in responsive view, and it's
worked correctly.
Which version of MDB and angular do you use?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#44 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AV0ynEUHqj68Qy_8V1fBE9UmnHqS3MwUks5tLxsngaJpZM4RekYH>
.
--
Adrien PAVILLETCO FONDATEUR+33 6 24 60 28 70
adrien@wertkt.com
https://wertkt.com
|
Dear pavillet, it's only a bug in our documentation site. If you use this code example in your's angular project, it works fine. We'll fix that bug. |
Sorry if that is not clear but the bug I see is on your documentation
https://mdbootstrap.com/angular/advanced/modals/
So I'm using the version you are using
2018-01-18 11:31 GMT+01:00 Bloodcast69 <notifications@github.com>:
… Please could you specify, which version of MDB and Angular do you use?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#44 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AV0ynGVwbNgxHPWZs5ZBKcHMxlCKvY5Iks5tLx2TgaJpZM4RekYH>
.
--
Adrien PAVILLETCO FONDATEUR+33 6 24 60 28 70
adrien@wertkt.com
https://wertkt.com
|
Now i know what you're talking about :) We'll fix this problem with our
site.
Best Regards,
Damian
2018-01-18 11:40 GMT+01:00 pavillet <notifications@github.com>:
… Sorry if that is not clear but the bug I see is on your documentation
https://mdbootstrap.com/angular/advanced/modals/
So I'm using the version you are using
2018-01-18 11:31 GMT+01:00 Bloodcast69 ***@***.***>:
> Please could you specify, which version of MDB and Angular do you use?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/mdbootstrap/Angular-Bootstrap-
with-Material-Design/issues/44#issuecomment-358605484>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/
AV0ynGVwbNgxHPWZs5ZBKcHMxlCKvY5Iks5tLx2TgaJpZM4RekYH>
> .
>
--
Adrien PAVILLETCO FONDATEUR+33 6 24 60 28 70 <+33%206%2024%2060%2028%2070>
***@***.***
https://wertkt.com
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#44 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AYjuxPi80Jn9X_ruTZFb1zzcE8NnK6ySks5tLx-lgaJpZM4RekYH>
.
|
Just to be clear I checked the doc because it's an issue we had on our site
( latest mdp angular free), so this might not be only on the website
2018-01-18 11:42 GMT+01:00 Bloodcast69 <notifications@github.com>:
… Now i know what you're talking about :) We'll fix this problem with our
site.
Best Regards,
Damian
2018-01-18 11:40 GMT+01:00 pavillet ***@***.***>:
> Sorry if that is not clear but the bug I see is on your documentation
> https://mdbootstrap.com/angular/advanced/modals/
>
> So I'm using the version you are using
>
> 2018-01-18 11:31 GMT+01:00 Bloodcast69 ***@***.***>:
>
> > Please could you specify, which version of MDB and Angular do you use?
> >
> > —
> > You are receiving this because you authored the thread.
> > Reply to this email directly, view it on GitHub
> > <https://github.com/mdbootstrap/Angular-Bootstrap-
> with-Material-Design/issues/44#issuecomment-358605484>,
> > or mute the thread
> > <https://github.com/notifications/unsubscribe-auth/
> AV0ynGVwbNgxHPWZs5ZBKcHMxlCKvY5Iks5tLx2TgaJpZM4RekYH>
>
> > .
> >
>
>
>
> --
> Adrien PAVILLETCO FONDATEUR+33 6 24 60 28 70
<+33%206%2024%2060%2028%2070> <+33%206%2024%2060%2028%2070>
> ***@***.***
> https://wertkt.com
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/mdbootstrap/Angular-Bootstrap-
with-Material-Design/issues/44#issuecomment-358607810>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AYjuxPi80Jn9X_
ruTZFb1zzcE8NnK6ySks5tLx-lgaJpZM4RekYH>
> .
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#44 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AV0ynAPpv0JlAu3au0Hzd0vn9wjr2-zPks5tLx_9gaJpZM4RekYH>
.
--
Adrien PAVILLETCO FONDATEUR+33 6 24 60 28 70
adrien@wertkt.com
https://wertkt.com
|
Did you encountered that case in your's angular project too? If yes, please
specify environment.
2018-01-18 11:43 GMT+01:00 pavillet <notifications@github.com>:
… Just to be clear I checked the doc because it's an issue we had on our site
( latest mdp angular free), so this might not be only on the website
2018-01-18 11:42 GMT+01:00 Bloodcast69 ***@***.***>:
> Now i know what you're talking about :) We'll fix this problem with our
> site.
> Best Regards,
> Damian
>
> 2018-01-18 11:40 GMT+01:00 pavillet ***@***.***>:
>
> > Sorry if that is not clear but the bug I see is on your documentation
> > https://mdbootstrap.com/angular/advanced/modals/
> >
> > So I'm using the version you are using
> >
> > 2018-01-18 11:31 GMT+01:00 Bloodcast69 ***@***.***>:
> >
> > > Please could you specify, which version of MDB and Angular do you
use?
> > >
> > > —
> > > You are receiving this because you authored the thread.
> > > Reply to this email directly, view it on GitHub
> > > <https://github.com/mdbootstrap/Angular-Bootstrap-
> > with-Material-Design/issues/44#issuecomment-358605484>,
> > > or mute the thread
> > > <https://github.com/notifications/unsubscribe-auth/
> > AV0ynGVwbNgxHPWZs5ZBKcHMxlCKvY5Iks5tLx2TgaJpZM4RekYH>
> >
> > > .
> > >
> >
> >
> >
> > --
> > Adrien PAVILLETCO FONDATEUR+33 6 24 60 28 70
<+33%206%2024%2060%2028%2070>
> <+33%206%2024%2060%2028%2070> <+33%206%2024%2060%2028%2070>
> > ***@***.***
> > https://wertkt.com
> >
> > —
> > You are receiving this because you commented.
> > Reply to this email directly, view it on GitHub
> > <https://github.com/mdbootstrap/Angular-Bootstrap-
> with-Material-Design/issues/44#issuecomment-358607810>,
> > or mute the thread
> > <https://github.com/notifications/unsubscribe-auth/AYjuxPi80Jn9X_
> ruTZFb1zzcE8NnK6ySks5tLx-lgaJpZM4RekYH>
> > .
>
> >
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/mdbootstrap/Angular-Bootstrap-
with-Material-Design/issues/44#issuecomment-358608172>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/
AV0ynAPpv0JlAu3au0Hzd0vn9wjr2-zPks5tLx_9gaJpZM4RekYH>
> .
>
--
Adrien PAVILLETCO FONDATEUR+33 6 24 60 28 70 <+33%206%2024%2060%2028%2070>
***@***.***
https://wertkt.com
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#44 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AYjuxF8w7M90s3cjHfm9Deem6lNIAvfRks5tLyBPgaJpZM4RekYH>
.
|
Same configuration with "angular-bootstrap-md": "^5.1.2",
2018-01-18 11:44 GMT+01:00 Bloodcast69 <notifications@github.com>:
… Did you encountered that case in your's angular project too? If yes, please
specify environment.
2018-01-18 11:43 GMT+01:00 pavillet ***@***.***>:
> Just to be clear I checked the doc because it's an issue we had on our
site
> ( latest mdp angular free), so this might not be only on the website
>
> 2018-01-18 11:42 GMT+01:00 Bloodcast69 ***@***.***>:
>
> > Now i know what you're talking about :) We'll fix this problem with our
> > site.
> > Best Regards,
> > Damian
> >
> > 2018-01-18 11:40 GMT+01:00 pavillet ***@***.***>:
> >
> > > Sorry if that is not clear but the bug I see is on your documentation
> > > https://mdbootstrap.com/angular/advanced/modals/
> > >
> > > So I'm using the version you are using
> > >
> > > 2018-01-18 11:31 GMT+01:00 Bloodcast69 ***@***.***>:
> > >
> > > > Please could you specify, which version of MDB and Angular do you
> use?
> > > >
> > > > —
> > > > You are receiving this because you authored the thread.
> > > > Reply to this email directly, view it on GitHub
> > > > <https://github.com/mdbootstrap/Angular-Bootstrap-
> > > with-Material-Design/issues/44#issuecomment-358605484>,
> > > > or mute the thread
> > > > <https://github.com/notifications/unsubscribe-auth/
> > > AV0ynGVwbNgxHPWZs5ZBKcHMxlCKvY5Iks5tLx2TgaJpZM4RekYH>
> > >
> > > > .
> > > >
> > >
> > >
> > >
> > > --
> > > Adrien PAVILLETCO FONDATEUR+33 6 24 60 28 70
<+33%206%2024%2060%2028%2070>
> <+33%206%2024%2060%2028%2070>
> > <+33%206%2024%2060%2028%2070> <+33%206%2024%2060%2028%2070>
> > > ***@***.***
> > > https://wertkt.com
> > >
> > > —
> > > You are receiving this because you commented.
> > > Reply to this email directly, view it on GitHub
> > > <https://github.com/mdbootstrap/Angular-Bootstrap-
> > with-Material-Design/issues/44#issuecomment-358607810>,
> > > or mute the thread
> > > <https://github.com/notifications/unsubscribe-auth/AYjuxPi80Jn9X_
> > ruTZFb1zzcE8NnK6ySks5tLx-lgaJpZM4RekYH>
> > > .
> >
> > >
> >
> > —
> > You are receiving this because you authored the thread.
> > Reply to this email directly, view it on GitHub
> > <https://github.com/mdbootstrap/Angular-Bootstrap-
> with-Material-Design/issues/44#issuecomment-358608172>,
> > or mute the thread
> > <https://github.com/notifications/unsubscribe-auth/
> AV0ynAPpv0JlAu3au0Hzd0vn9wjr2-zPks5tLx_9gaJpZM4RekYH>
>
> > .
> >
>
>
>
> --
> Adrien PAVILLETCO FONDATEUR+33 6 24 60 28 70
<+33%206%2024%2060%2028%2070> <+33%206%2024%2060%2028%2070>
> ***@***.***
> https://wertkt.com
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/mdbootstrap/Angular-Bootstrap-
with-Material-Design/issues/44#issuecomment-358608492>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/
AYjuxF8w7M90s3cjHfm9Deem6lNIAvfRks5tLyBPgaJpZM4RekYH>
> .
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#44 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AV0ynMsr8vwpBNF1ok8jh6n14JLLPPqkks5tLyCbgaJpZM4RekYH>
.
--
Adrien PAVILLETCO FONDATEUR+33 6 24 60 28 70
adrien@wertkt.com
https://wertkt.com
|
Thanks for report. I'll check this case and let you know later.
Regards,
Damian
2018-01-18 12:13 GMT+01:00 pavillet <notifications@github.com>:
… Same configuration with "angular-bootstrap-md": "^5.1.2",
2018-01-18 11:44 GMT+01:00 Bloodcast69 ***@***.***>:
> Did you encountered that case in your's angular project too? If yes,
please
> specify environment.
>
>
> 2018-01-18 11:43 GMT+01:00 pavillet ***@***.***>:
>
> > Just to be clear I checked the doc because it's an issue we had on our
> site
> > ( latest mdp angular free), so this might not be only on the website
> >
> > 2018-01-18 11:42 GMT+01:00 Bloodcast69 ***@***.***>:
> >
> > > Now i know what you're talking about :) We'll fix this problem with
our
> > > site.
> > > Best Regards,
> > > Damian
> > >
> > > 2018-01-18 11:40 GMT+01:00 pavillet ***@***.***>:
> > >
> > > > Sorry if that is not clear but the bug I see is on your
documentation
> > > > https://mdbootstrap.com/angular/advanced/modals/
> > > >
> > > > So I'm using the version you are using
> > > >
> > > > 2018-01-18 11:31 GMT+01:00 Bloodcast69 ***@***.***>:
> > > >
> > > > > Please could you specify, which version of MDB and Angular do you
> > use?
> > > > >
> > > > > —
> > > > > You are receiving this because you authored the thread.
> > > > > Reply to this email directly, view it on GitHub
> > > > > <https://github.com/mdbootstrap/Angular-Bootstrap-
> > > > with-Material-Design/issues/44#issuecomment-358605484>,
> > > > > or mute the thread
> > > > > <https://github.com/notifications/unsubscribe-auth/
> > > > AV0ynGVwbNgxHPWZs5ZBKcHMxlCKvY5Iks5tLx2TgaJpZM4RekYH>
> > > >
> > > > > .
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Adrien PAVILLETCO FONDATEUR+33 6 24 60 28 70
<+33%206%2024%2060%2028%2070>
> <+33%206%2024%2060%2028%2070>
> > <+33%206%2024%2060%2028%2070>
> > > <+33%206%2024%2060%2028%2070> <+33%206%2024%2060%2028%2070>
> > > > ***@***.***
> > > > https://wertkt.com
> > > >
> > > > —
> > > > You are receiving this because you commented.
> > > > Reply to this email directly, view it on GitHub
> > > > <https://github.com/mdbootstrap/Angular-Bootstrap-
> > > with-Material-Design/issues/44#issuecomment-358607810>,
> > > > or mute the thread
> > > > <https://github.com/notifications/unsubscribe-auth/AYjuxPi80Jn9X_
> > > ruTZFb1zzcE8NnK6ySks5tLx-lgaJpZM4RekYH>
> > > > .
> > >
> > > >
> > >
> > > —
> > > You are receiving this because you authored the thread.
> > > Reply to this email directly, view it on GitHub
> > > <https://github.com/mdbootstrap/Angular-Bootstrap-
> > with-Material-Design/issues/44#issuecomment-358608172>,
> > > or mute the thread
> > > <https://github.com/notifications/unsubscribe-auth/
> > AV0ynAPpv0JlAu3au0Hzd0vn9wjr2-zPks5tLx_9gaJpZM4RekYH>
> >
> > > .
> > >
> >
> >
> >
> > --
> > Adrien PAVILLETCO FONDATEUR+33 6 24 60 28 70
<+33%206%2024%2060%2028%2070>
> <+33%206%2024%2060%2028%2070> <+33%206%2024%2060%2028%2070>
> > ***@***.***
> > https://wertkt.com
> >
> > —
> > You are receiving this because you commented.
> > Reply to this email directly, view it on GitHub
> > <https://github.com/mdbootstrap/Angular-Bootstrap-
> with-Material-Design/issues/44#issuecomment-358608492>,
> > or mute the thread
> > <https://github.com/notifications/unsubscribe-auth/
> AYjuxF8w7M90s3cjHfm9Deem6lNIAvfRks5tLyBPgaJpZM4RekYH>
>
> > .
> >
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/mdbootstrap/Angular-Bootstrap-
with-Material-Design/issues/44#issuecomment-358608808>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/
AV0ynMsr8vwpBNF1ok8jh6n14JLLPPqkks5tLyCbgaJpZM4RekYH>
> .
>
--
Adrien PAVILLETCO FONDATEUR+33 6 24 60 28 70 <+33%206%2024%2060%2028%2070>
***@***.***
https://wertkt.com
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#44 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AYjuxDM5lYKkGP834nof6mN7X81TOtS8ks5tLydIgaJpZM4RekYH>
.
|
It seems to be fixed, closing |
Hello and thanks for the work,
From screenshot you can see header and footer are not contained in the modal in case of modal-fluid. This is from the docs
The text was updated successfully, but these errors were encountered: