Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Carousel SCSS arrow image paths changed to use $image-path variable #124

Closed

Conversation

latotty
Copy link

@latotty latotty commented Jul 18, 2019

Bug:
With the 8.0.0 update, the carousel scss included literal paths to the arrow images, which failed to build, when we wanted to use the scss from the styles.scss and not from the angular.json.

Fix:
Changed the image paths, to use the path variables ($carousel-control-prev-icon, $carousel-control-next-icon) (already present in the 8.0.0 version).
Changed the path variables ($carousel-control-prev-icon, $carousel-control-next-icon) to include the $image-path variable

The bug has been reported already by an other user: https://mdbootstrap.com/support/angular/build-errors/

@Bloodcast69
Copy link
Contributor

This problem will be resolved with the next version of MDB Angular (next two weeks). So I'm closing this PR.

@latotty
Copy link
Author

latotty commented Jul 19, 2019

@Bloodcast69 Couldn't you release a fix for this in a patch version? This is blocker for us. If we have to wait 2 weeks, we need to find an alternative.

@Bloodcast69
Copy link
Contributor

@latotty The whole MDB Angular Free should be working fine without our fix.

Could you please show me the code which causes you those problems? I would like to debug it.

The workaround for this situation is just to do not import the whole mdb.scss file in styles.scss file, and you shouldn't get those errors.

@latotty
Copy link
Author

latotty commented Jul 19, 2019

@Bloodcast69 Yeah, but we want to use the scss variables. We want to customise the colors, for example. What is the point of creating the framework in scss with variables in mind, if we can't use it that way?

This is just an example:
styles.scss

$primary-color: #d00000;
$primary: #d00000;
$image-path: '../node_modules/angular-bootstrap-md/assets/img/';
$roboto-font-path: '../node_modules/angular-bootstrap-md/assets/font/roboto/';


@import '~angular-bootstrap-md/assets/scss/bootstrap/bootstrap.scss';
@import '~angular-bootstrap-md/assets/scss/mdb.scss';

@Bloodcast69
Copy link
Contributor

@latotty are you building your app on top of this repository? Or you're using only angular-bootstrap-md dependency from npmjs repository?

@latotty
Copy link
Author

latotty commented Jul 19, 2019

@Bloodcast69 We are using it from npm.

@Bloodcast69
Copy link
Contributor

Please contact with me via email. You can find me here: d.gemza@mdbootstrap.com

@latotty
Copy link
Author

latotty commented Jul 19, 2019

May I ask why?

We found a bug in your package, which is a blocker for our team.
Our way of using the package is normal, in every way.
We found that the bug was already reported on the forums x days ago.
We created a PR with a fix, and hoped you could release it via a patch release, because thats usually how packages work.
You refused to use our, or any fix, and told us to wait 2 weeks until you fix the issue, making the package usable again.

So with all due respect, we replaced this package with an other, so you now have all the time in the world to implement fixes.

@Bloodcast69
Copy link
Contributor

I wanted to describe you, what you should do to resolve this problem in your application.

We can't do hotfix right now, because the next release is ready in 100% and there's no possibility to put there some changes.

I'm very sorry that you and your team decided to refuse to use our product. If you'll decide to back to us, we'll be very glad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants