use scrollHeight & scrollWidth to avoid getting the wrong size of the content #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! With a quick look, the patch looks nice. I reviewed the patch and I'd like to make some comments. First, please remove the lines commented with '//'. Second, I think $this.prop('scrollHeight') and $this.prop('scrollWidth') look better with other lines. Thank you very much for the pull request! |
|
I'll merge the pull request when I'm home and have some tests with IE. Thank you! |
|
Works very well in win7 ie8! And even, this patch resolve the multiple children problem!! Thank you very much. |
hatashiro
pushed a commit
that referenced
this pull request
Jun 14, 2013
Use prop('scrollWidth') and prop('scrollHeight') instead of outerWidth() and outerHeight() to get the content size.
hatashiro
pushed a commit
that referenced
this pull request
Apr 29, 2014
Use prop('scrollWidth') and prop('scrollHeight') instead of outerWidth() and outerHeight() to get the content size.
hatashiro
pushed a commit
that referenced
this pull request
Sep 24, 2014
Use prop('scrollWidth') and prop('scrollHeight') instead of outerWidth() and outerHeight() to get the content size.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use $this[0].scrollHeight & $this[0].scrollWidth to avoid getting the wrong size of the content