Use vertical scroll for horizontal scrollbar if only horizontal scrollbar is present #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good! But how about making it optional? Conventionally, the features that is not supported by native scrollbar have been adopted with optional parameters. You can find the example of the optional feature here: #48. And the min files should not be included. Please remove them from the diff. Thank you! |
|
Done, updated docs too. Let me know if it's alright. |
…nly one axe is scrollable
|
Seems good! And for the last one, I'm very sorry but can you add an example code in 'examples' directory? Thank you. |
hatashiro
pushed a commit
that referenced
this pull request
Sep 30, 2013
Use vertical scroll for horizontal scrollbar if only horizontal scrollbar is present.
|
Never mind. I've added an example while refactoring the code :D Thank you very much! |
|
Was going to take a stab at it today... Anyway, awesome! |
hatashiro
pushed a commit
that referenced
this pull request
Apr 29, 2014
Use vertical scroll for horizontal scrollbar if only horizontal scrollbar is present.
hatashiro
pushed a commit
that referenced
this pull request
Sep 24, 2014
Use vertical scroll for horizontal scrollbar if only horizontal scrollbar is present.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might be slightly more convenient to be able to use vertical scroll wheel for horizontal scrollbar if vertical scrollbar is not present, what do you think?