Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touch effect on checkboxes happening on mouseup instead of mousedown #58

Closed
StewartAtkins opened this issue Oct 1, 2014 · 4 comments
Closed
Labels

Comments

@StewartAtkins
Copy link

With elements like nav bar items and buttons the ripple effect occurs on mousedown. This appears to be consistent with official material design examples.

Checkboxes and radio buttons have no ripple effect on mousedown, with a brief ripple instead triggering on mouseup. This doesn't line up with expected ripple behaviour, or with the material demos available here https://www.polymer-project.org/components/paper-elements/demo.html#paper-radio-button

@FezVrasta
Copy link
Contributor

There's not a way to run the effect on mouse down without javascript...

@npirotte
Copy link

npirotte commented Oct 1, 2014

Note that the google implementation is buggy : if ou mousedown on the checkbox then move the mouse out without mouse up the ripple will stay forever (until a mouseup occurs ...)

@StewartAtkins
Copy link
Author

It seems somewhat strange to exclude a possible behaviour because it would be javascript dependent, when the component itself, as well as all the other ripple effects are also JS dependent.

@FezVrasta
Copy link
Contributor

I'm trying to keep the theme less js powered. the current effect is very good I think, maybe we could add a js plugin which improves the effect when js is active...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants