Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected shouldBeConsumedByChild logic for vertical scrolling #140

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Corrected shouldBeConsumedByChild logic for vertical scrolling #140

wants to merge 1 commit into from

Conversation

tibineagu
Copy link

@tibineagu tibineagu commented Jul 12, 2022 •
edited

Fixes #139

Thank you very much for your contribution! Please make sure the followings
are checked.

  • Read CONTRIBUTING.md
  • Run npm test to make sure it formats and build successfully
  • Provide the scenario this PR will address(some JSFiddles will be perfect)
    • addressed in tagged issue
  • Refer to concerning issues if exist

Description

Because deltaY is negative when the user is scrolling down, the logic in shouldBeConsumedByChild for vertical scrolling was flawed.

The solution was simply adjusting the > / < operators to match the deltaY values.

@tibineagu tibineagu mentioned this pull request Jul 12, 2022
Open
4 tasks
@tibineagu
Copy link
Author

@filipkappa @marveluck @mdbootstrap any feedback or ETA for this being integrated?

@mauricio-lomeli-planview
Copy link

There is no PRs which have ever been accepted and the latest was about a year ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scrolling broken when cursor hovering over overflowing textarea
2 participants
@tibineagu @mauricio-lomeli-planview