Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling when season has no poster #7

Closed
mstrelan opened this issue Feb 19, 2013 · 1 comment
Closed

Better handling when season has no poster #7

mstrelan opened this issue Feb 19, 2013 · 1 comment

Comments

@mstrelan
Copy link
Contributor

Currently if a season has no poster on thetvdb.com the script will just throw an IOError. In this case I think it would be ideal to then find a poster for the series instead. If that doesn't exist we need to skip adding a poster.

An example of a show like this is 90210 Season 5 (my wife watches it).
http://thetvdb.com/?tab=season&seriesid=82716&seasonid=493163&lid=7

Probably the first "poster" for the series would be best.
http://thetvdb.com/?tab=series&id=82716&lid=7

Full output below of the error below.

C:>python "C:\Users\Michael\SickBeard\sickbeard_mp4_automator\postConversion.py
" "D:\TV Shows\90210\Season 5\90210 5x14 Brother From Another Mother.mkv" I:\Dow
nloads\Usenet\Complete\90210.S05E14.720p.HDTV.x264-EVOLVE\90210.S05E14.720p.HDTV
.x264-EVOLVE.mkv 82716 5 14 2013-02-18
Video codec detected: h264
Audiocodec detected: ac3
Channels detected: 6
[ ] 0%
[ ] 1%
[ ] 1%
[ ] 2%
[ ] 2%
[ ] 3%
[ ] 4%
[ ] 4%
[ ] 5%
[ ] 5%
[ ] 6%
[ ] 6%
[ ] 7%
[ ] 7%
[ ] 8%
[ ] 9%
[ ] 9%
[# ] 10%
[# ] 11%
[# ] 11%
[# ] 12%
[# ] 12%
[# ] 13%
[# ] 13%
[# ] 14%
[# ] 14%
[# ] 15%
[# ] 16%
[# ] 16%
[# ] 17%
[# ] 17%
[# ] 18%
[# ] 18%
[# ] 19%
[# ] 19%
[## ] 20%
[## ] 20%
[## ] 21%
[## ] 21%
[## ] 22%
[## ] 22%
[## ] 23%
[## ] 24%
[## ] 24%
[## ] 25%
[## ] 25%
[## ] 26%
[## ] 26%
[## ] 27%
[## ] 27%
[## ] 28%
[## ] 28%
[## ] 29%
[## ] 29%
[### ] 30%
[### ] 30%
[### ] 31%
[### ] 31%
[### ] 32%
[### ] 33%
[### ] 33%
[### ] 34%
[### ] 34%
[### ] 35%
[### ] 35%
[### ] 36%
[### ] 36%
[### ] 37%
[### ] 38%
[### ] 38%
[### ] 39%
[### ] 39%
[### ] 39%
[#### ] 40%
[#### ] 41%
[#### ] 41%
[#### ] 41%
[#### ] 42%
[#### ] 43%
[#### ] 43%
[#### ] 43%
[#### ] 44%
[#### ] 44%
[#### ] 45%
[#### ] 45%
[#### ] 46%
[#### ] 47%
[#### ] 47%
[#### ] 48%
[#### ] 48%
[#### ] 49%
[#### ] 49%
[##### ] 50%
[##### ] 50%
[##### ] 51%
[##### ] 51%
[##### ] 52%
[##### ] 52%
[##### ] 53%
[##### ] 53%
[##### ] 54%
[##### ] 54%
[##### ] 55%
[##### ] 55%
[##### ] 56%
[##### ] 57%
[##### ] 57%
[##### ] 57%
[##### ] 58%
[##### ] 58%
[##### ] 59%
[##### ] 59%
[###### ] 60%
[###### ] 61%
[###### ] 61%
[###### ] 61%
[###### ] 62%
[###### ] 62%
[###### ] 63%
[###### ] 63%
[###### ] 64%
[###### ] 64%
[###### ] 65%
[###### ] 65%
[###### ] 66%
[###### ] 66%
[###### ] 67%
[###### ] 67%
[###### ] 67%
[###### ] 68%
[###### ] 68%
[###### ] 69%
[###### ] 69%
[###### ] 69%
[####### ] 70%
[####### ] 70%
[####### ] 71%
[####### ] 71%
[####### ] 72%
[####### ] 72%
[####### ] 73%
[####### ] 73%
[####### ] 74%
[####### ] 74%
[####### ] 75%
[####### ] 75%
[####### ] 76%
[####### ] 76%
[####### ] 77%
[####### ] 77%
[####### ] 78%
[####### ] 78%
[####### ] 79%
[####### ] 79%
[######## ] 80%
[######## ] 81%
[######## ] 81%
[######## ] 82%
[######## ] 82%
[######## ] 83%
[######## ] 83%
[######## ] 84%
[######## ] 84%
[######## ] 85%
[######## ] 86%
[######## ] 86%
[######## ] 87%
[######## ] 87%
[######## ] 88%
[######## ] 88%
[######## ] 89%
[######## ] 89%
[######### ] 90%
[######### ] 91%
[######### ] 91%
[######### ] 92%
[######### ] 92%
[######### ] 92%
[######### ] 93%
[######### ] 94%
[######### ] 94%
[######### ] 95%
[######### ] 95%
[######### ] 96%
[######### ] 96%
[######### ] 97%
[######### ] 97%
[######### ] 98%
[######### ] 99%
[######### ] 99%
[##########] 100%
Conversion complete
90210 has queued to be refreshed
{}
success
Tagging file :D:\TV Shows\90210\Season 5\90210 5x14 Brother From Another Moth
er.m4v
Traceback (most recent call last):
File "C:\Users\Michael\SickBeard\sickbeard_mp4_automator\postConversion.py", l
ine 30, in
tagmp4.writeTags(path)
File "C:\Users\Michael\SickBeard\sickbeard_mp4_automator\tvdb_mp4.py", line 54
, in writeTags
path = self.getArtwork()
File "C:\Users\Michael\SickBeard\sickbeard_mp4_automator\tvdb_mp4.py", line 15
8, in getArtwork
return urllib.urlretrieve(posters.topPoster().bannerpath, tempfile.gettempdi
r() + "\poster.jpg")[0]
File "C:\Python27\lib\urllib.py", line 93, in urlretrieve
return _urlopener.retrieve(url, filename, reporthook, data)
File "C:\Python27\lib\urllib.py", line 239, in retrieve
fp = self.open(url, data)
File "C:\Python27\lib\urllib.py", line 207, in open
return getattr(self, name)(url)
File "C:\Python27\lib\urllib.py", line 462, in open_file
return self.open_local_file(url)
File "C:\Python27\lib\urllib.py", line 476, in open_local_file
raise IOError(e.errno, e.strerror, e.filename)
IOError: [Errno 2] The system cannot find the path specified: ''

@mdhiggins
Copy link
Owner

Fixed, if it can't find a poster now it will simply not write that atom

When I get some more time I'll write some code to pull down a generic show poster but at least now it doesn't fail completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants