Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling installation in Windows (Following up issue #88) #113

Closed
LateButSteady opened this issue Dec 27, 2023 · 2 comments
Closed

Enabling installation in Windows (Following up issue #88) #113

LateButSteady opened this issue Dec 27, 2023 · 2 comments

Comments

@LateButSteady
Copy link
Contributor

LateButSteady commented Dec 27, 2023 •
edited
Loading

Problem

  • python setup.py install fails in windows OS
  • Error message: error C3861: “sincos”: Could not find the identifier (Already reported in issue Install Problem #88 )

Cause

  • The function "sincos" is only supported in Linux, not in Windows.

Is it okay that I modify the code to enable installation in Windows?
I will define the "sincos" function in the files below after detecting OS.

  • symmetry_functions.h
  • pair_nn_simd_function.h
@LateButSteady
Copy link
Contributor Author

I submitted a Pull Request to solve this issue.

JisuJung928 added a commit that referenced this issue Dec 29, 2023
@JisuJung928
Merge pull request #114 from LateButSteady/inst_win
d69dc23 
Enabling setup.py installation in Windows (Following issue #113, #88)
@JisuJung928
Copy link
Member

Thank you for your contribution!

#114 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JisuJung928 @LateButSteady