Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that object graphs are collected from secure context #43

Open
foolip opened this issue Jan 5, 2018 · 0 comments
Open

Ensure that object graphs are collected from secure context #43

foolip opened this issue Jan 5, 2018 · 0 comments

Comments

@foolip
Copy link
Collaborator

foolip commented Jan 5, 2018

I've been playing with https://github.com/mdittmer/web-apis#manual-data-collection-setup to get data from browsers (and versions) not available on BrowserStack.

Setting it up, I could use HTTPS or not, and the easiest thing for me would be to use HTTPS since I have HSTS enabled on foolip.org which I'd use to test.

Since more APIs are exposed on secure contexts, it would make sense to assert in the data collection that isSecureContext is either undefined or true, but never false. The assumption is that any browser that limits any API to secure contexts will also have isSecureContext.

@mdittmer, does this make sense, and where would the check have to be to also fail in the case of automated data collection from BrowserStack?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant