Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI improvements #7

Closed
MisterMakerNL opened this issue Oct 3, 2022 · 11 comments
Closed

UI improvements #7

MisterMakerNL opened this issue Oct 3, 2022 · 11 comments

Comments

@MisterMakerNL
Copy link

MisterMakerNL commented Oct 3, 2022

I got asked to check if my Dark theme need adjusting for the Piemenu, but it seems to work just fine.
Although I see 2 small UI bugs:
afbeelding
Edit2:
a third is the arrows they cut in the text:
afbeelding

Edit:
btw Super awesome you are picking this project up!

@mdkus
Copy link
Owner

mdkus commented Oct 3, 2022

Thank you for your tests. I'll try to reproduce this.

@mdkus
Copy link
Owner

mdkus commented Oct 3, 2022

Ok, the first two bugs are reproducible for me (Windows 11):
ExtremeProDark_1

The third not:
ExtremeProDark_2
Is there any option to enlarge menu texts in FreeCAD? I haven't found it yet...

@MisterMakerNL
Copy link
Author

Aha I see the last bug was only in 0.21, when I checked it in 0.20.1 it works!

Below version stats, might already been fixed, I don't think I am running the latest 0.21.
[code]
OS: Windows 10 Version 2009
Word size of FreeCAD: 64-bit
Version: 0.21.30345 (Git)
Build type: Release
Branch: master
Hash: f42a47aa0fd8c4f34ef63c185d9f29b9b6e84737
Python 3.10.6, Qt 5.15.4, Coin 4.0.0, Vtk 9.1.0, OCC 7.6.3
Locale: Dutch/Netherlands (nl_NL)
Installed mods:

  • Assembly3 0.11.3
  • Behave-Dark-Colors 0.1.1
  • BIM 2021.12.0 (Disabled)
  • Dracula 0.0.2
  • ExtremeProDark 2.2.0
  • FeedsAndSpeeds 0.4.0
  • FEM_FrontISTR 0.1.0
  • IconThemes
  • lattice2 1.0.0
  • PieMenu 1.1.6
  • PieMenu.backup1664822562.2342157
  • ProDarkThemePreferencePack 1.0.0
  • SelectorToolbar
  • sheetmetal 0.2.57
  • SP_Startup
  • ToolbarStyle
    [/code]

@mdkus
Copy link
Owner

mdkus commented Oct 4, 2022

Thanks for the info! Where can I find 0.21? Is that the actual FC master?

@MisterMakerNL
Copy link
Author

https://github.com/FreeCAD/FreeCAD-Bundle/releases/tag/weekly-builds

@MisterMakerNL
Copy link
Author

I noticed the blue bar on another tab bar, and realize it is an error in my theme so I dove into it and fixed it a bit:
afbeelding

@mdkus
Copy link
Owner

mdkus commented Oct 5, 2022

In 0.20.1 you also fixed the second bug. In 0.21 it works too.
ExtremeProDark_3
Only the third bug remains for 0.21, but not in 0.20.1:
ExtremeProDark_4

@mdkus
Copy link
Owner

mdkus commented Nov 4, 2022

@MisterMakerNL The new update of pie menu (1.1.12) should fix the third bug. Please check out. Tested with v0.21 Python 3.10:

ExtremeProDark_5

But one problem still remains: In dark mode all checkable items are shown checked although they aren't.

ExtremeProDark_6
ExtremeProDark_7

Any idea?

@MisterMakerNL
Copy link
Author

MisterMakerNL commented Nov 20, 2022

Edit:
One icon is missing the unchecked check mark light.
Other things where links to icons in my theme!
So I fixed the biggest issue in the ExtremeProDark, it's not perfect yet.
It also needs to be pushed to main, as all dark theme's are missing this icons.
MisterMakerNL/ExtremeProDark@117147d
freecad_8hMYstDyyL

@mdkus
Copy link
Owner

mdkus commented Nov 21, 2022

@MisterMakerNL
Good collab. Can we close this issue?

@MisterMakerNL
Copy link
Author

Yeah, looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants