-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code line numbers overlap with line content. #980
Comments
I've also hit it in the past, and there are duplicate issues: mdn/content#13531 This isn't reproduced consistently in my browser—in fact, probably once every 100 visits—and usually works after a refresh. But I have a feeling this has something to do with wrong hydration order. @mdn/core-dev it's probably a pain but could you investigate? |
Not a consistent repro. Navigation using links inside the page - persists the issue. Full Refresh (F5) of the page - clears the issue.
With proper render:
Main differences: Looks like Code related component has an issue with maintaining showLineNumbers state, and sometimes got into state when numbers are shown but component set all styling as they are hidden. |
Was able to get repro with 3/5 rate.
Google Chrome Version 103.0.5060.134 (Official Build) (x86_64) |
FWIW @NiedziolkaMichal has reported the issue upstream: codemirror/codemirror5#6953 |
@caugner Yes, but issue is with our implementation of code mirror. Version 6 was released quite recently which I think wouldn't have this problem(we use 5.65.8), but its API is significantly different. I could work on upgrading it, but currently I have 6 PRs in BOB waiting for a review, so its likely that I would be wasting my time. |
Duplicate of #976. |
MDN URL
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/assign
What specific section or headline is this issue about?
"Try it"
What information was incorrect, unhelpful, or incomplete?
Nothing was incorrect.
There is a problem with the layout of the editable code box under "Try it" where line numbers overlap code and make code hard to read.
What did you expect to see?
For line numbers to not overlap with code.
Do you have any supporting links, references, or citations?
https://imgur.com/rt0YFBv
Do you have anything more you want to share?
Steps to reproduce:
1- Open "https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/assign" with Firefox.
2- Check the "Try it" section.
MDN metadata
Page report details
en-us/web/javascript/reference/global_objects/object/assign
The text was updated successfully, but these errors were encountered: