Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Schema] Disallow dots in feature identifiers #167

Closed
Elchi3 opened this issue May 3, 2017 · 0 comments
Closed

[Schema] Disallow dots in feature identifiers #167

Elchi3 opened this issue May 3, 2017 · 0 comments
Assignees
Labels
schema ⚙️ Isses or pull requests regarding the JSON schema files used in this project.

Comments

@Elchi3
Copy link
Member

Elchi3 commented May 3, 2017

We should disallow dots in feature identifiers as we are using them to access features and they are indicating a nested structure. (kumascript accesses these nested structures with say {{compat("webextensions.api.devtools.inspectedWindow")}} and thus expects a nested object structure)

"devtools.inspectedWindow": { ... } shouldn't be in the JSON, it should be nested like "devtools": { "inspectedWindow": { ... } } etc.

Helpful resource to create this schema rule: https://spacetelescope.github.io/understanding-json-schema/reference/regular_expressions.html.

@Elchi3 Elchi3 added the schema ⚙️ Isses or pull requests regarding the JSON schema files used in this project. label May 4, 2017
@Elchi3 Elchi3 self-assigned this May 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
schema ⚙️ Isses or pull requests regarding the JSON schema files used in this project.
Projects
None yet
Development

No branches or pull requests

1 participant