Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api.Cache.add - Deno doesn't support this (and the addAll) method #18235

Closed
nnmrts opened this issue Nov 17, 2022 · 0 comments · Fixed by #18346
Closed

api.Cache.add - Deno doesn't support this (and the addAll) method #18235

nnmrts opened this issue Nov 17, 2022 · 0 comments · Fixed by #18346
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API

Comments

@nnmrts
Copy link

nnmrts commented Nov 17, 2022

What type of issue is this?

Incorrect support data (ex. Chrome says "86" but support was added in "40")

What information was incorrect, unhelpful, or incomplete?

The table says Cache.add is supported since 1.26 (added in this PR), but it is not. It wasn't supported in 1.26 and it isn't in 1.28.1

What browsers does this problem apply to, if applicable?

Deno

What did you expect to see?

No support

Did you test this? If so, how?

Run Deno REPL:

> const cache = await caches.open("test"); cache.add("https://google.com");

Uncaught TypeError: cache.add is not a function
    at <anonymous>:3:7

Can you link to any release notes, bugs, pull requests, or MDN pages related to this?

#18056
https://developer.mozilla.org/en-US/docs/Web/API/Cache/add#browser_compatibility

Do you have anything more you want to share?

The official Deno documentation doesn't mention it either: https://deno.land/api@v1.28.1?s=Cache

The "source" given by @bartlomieju and looked over by @queengooborg also doesn't mention add or addAll as well.

Searching for addAll in the Deno repository leads me to believe that the two methods are only supported in Workers, but I don't really know.

MDN URL

https://developer.mozilla.org/en-US/docs/Web/API/Cache/add

MDN metadata

MDN page report details
  • Query: api.Cache.add
  • Report started: 2022-11-17T15:20:38.556Z
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants