Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Represent "user must provide permission" in the schema #191

Closed
stephaniehobson opened this issue May 15, 2017 · 3 comments
Closed

Represent "user must provide permission" in the schema #191

stephaniehobson opened this issue May 15, 2017 · 3 comments
Labels
schema ⚙️ Isses or pull requests regarding the JSON schema files used in this project.

Comments

@stephaniehobson
Copy link

Features like geolocation, battery, and some types of storage require the user to authorize the site to access that feature.

We should have a way to record and display when this is the case.

@Elchi3 Elchi3 added the schema ⚙️ Isses or pull requests regarding the JSON schema files used in this project. label May 16, 2017
@Elchi3
Copy link
Member

Elchi3 commented May 17, 2017

I think this would be an optional property in simple_support_statement:

"simple_support_statement": {
  "type": "object",
  "properties": {
    "prefix": { "type": "string" },
    "alternative_name": { "type": "string" },
    "flag": ...,
    "partial_implementation": { "type": "boolean" },
    "user_permission_required: { "type": "boolean" },
    ...
  }
},

Does user_permission_required sound good to you? Is this a boolean type or something else?

@stephaniehobson
Copy link
Author

Boolean is good, additional information can be provided in the notes if necessary.

Maybe just permission_required? FxOS has some features that the OS only granted permissions to if the developer was trusted. If those cases show up again we could use the same property for those (though, maybe we do not want to do that in which case user_permission_required is good.

@Elchi3
Copy link
Member

Elchi3 commented Dec 1, 2017

See the discussion in #190.
tl;dr we are not adding a new user_permission_required property and sub features should be used if the user permission was required at a later point than the basic support of the API.

@Elchi3 Elchi3 closed this as completed Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
schema ⚙️ Isses or pull requests regarding the JSON schema files used in this project.
Projects
None yet
Development

No branches or pull requests

2 participants