Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webextensions.manifest.action - Chrome does not support "theme_icons" key #23151

Open
monyxie opened this issue May 22, 2024 · 0 comments
Open
Labels
data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions

Comments

@monyxie
Copy link

monyxie commented May 22, 2024

What type of issue is this?

Incorrect support data (example: BrowserX says "86" but support was added in "40")

What information was incorrect, unhelpful, or incomplete?

action.theme_icons key is listed in the comatibility table as support by Chrome since version 88.

What browsers does this problem apply to, if applicable?

No response

What did you expect to see?

action.theme_icons key should be listed as unsupported by Chrome.

Did you test this? If so, how?

I tested this in Chromium v125.0.6422.41 with a manifest.json file that look something like this:

{
  "manifest_version": 3,

  ...

  "icons": {
    "16": "icons/qrlite-16.png",
    "32": "icons/qrlite-32.png",
    "64": "icons/qrlite-48.png",
    "128": "icons/qrlite-128.png"
  },
  "action": {
    "default_icon": {
      "16": "icons/qrlite-light-16.png",
      "32": "icons/qrlite-light-32.png",
      "48": "icons/qrlite-light-48.png",
      "128": "icons/qrlite-light-128.png"
    },
    "default_popup": "popup/popup.html",
    "theme_icons": [
      {
        "light": "icons/qrlite-dark-16.png",
        "dark": "icons/qrlite-light-16.png",
        "size": 16
      },
      {
        "light": "icons/qrlite-dark-32.png",
        "dark": "icons/qrlite-light-32.png",
        "size": 32
      }
    ]
  },
  
  ...

}

The action icon does not change when I switch between light and dark mode.

Can you link to any release notes, bugs, pull requests, or MDN pages related to this?

Chrome Extensions API Reference: https://developer.chrome.com/docs/extensions/reference/api/action
Relevant source code: Chromium v88 , Chromium v127

Do you have anything more you want to share?

No response

MDN URL

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/action

MDN metadata

MDN page report details
  • Query: webextensions.manifest.action
  • Report started: 2024-05-22T09:19:57.519Z
@queengooborg queengooborg added the data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions
Projects
None yet
Development

No branches or pull requests

3 participants
@monyxie @queengooborg and others