New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OfflineAudioContext#resume is available on Firefox #6733
Comments
@saschanaz mdn-bcd-collector is intentionally using more lax tests like (function () {
var instance = new (window.AudioContext || window.webkitAudioContext)();
return 'resume' in instance;
})(); The reason for this is that there are so many little mishaps in implementations and differences in which prototype things live on that ultimately don't matter to the question "can I use this?" However, sometimes a situation like this warrants a note. Currently we don't discover the situation automatically, but we could: foolip/mdn-bcd-collector#523 |
As for AudioContext#resume and OfflineAudioContext#resume, both exist in the spec: If Firefox has put these on |
Ah cool, let's mark the OfflineAudioContext one as supported in Firefox and I'll be good then. |
@vinyldarkscratch https://mdn-bcd-collector.appspot.com/tests/api/OfflineAudioContext says this is supported in Firefox, and I made an attempt to quickfix, but ran into foolip/mdn-bcd-collector#531. This is probably not an isolated problem, so would you be able to self-assign both this and that issue, and use this as the example to prove it working better? |
With the fixes in foolip/mdn-bcd-collector#532 the update script does set OfflineAudioContext#resume to added in Firefox 40. @vinyldarkscratch I won't send a PR for just one entry, can you bake that into a larger PR fixing things with Web Audio? |
This looks fixed to me. Please reopen if not. |
Yep, the data was updated in #14291. |
@foolip, mdn-bcd-collector currently says both
AudioContext.resume
andOfflineAudioContext.resume
are available on Firefox but actually they are fromBaseAudioContext
. Should it check their existence byhasOwnProperty
?(Chrome somehow does have separate
AudioContext.resume
andOfflineAudioContext.resume
🤔)The text was updated successfully, but these errors were encountered: