Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebAPI] WebRTC Deprecate non-standard frameRateMean and frameRateStdDev stats #10858

Closed
7 tasks done
Rumyra opened this issue Nov 29, 2021 · 6 comments
Closed
7 tasks done
Assignees
Labels
Content:WebAPI Web API docs fx release archive A closed issue relating to firefox release notes for developers. needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.

Comments

@Rumyra
Copy link
Collaborator

Rumyra commented Nov 29, 2021

Acceptance Criteria

  • The listed features are documented sufficiently on MDN
  • BCD is updated - NA
  • Interactive example and data repos are updated if appropriate - NA
  • The content has been reviewed as needed

For folks helping with Firefox related documentation

  • Set bugs to dev-doc-complete
  • Add entry to Firefox release notes if feature is enabled in release
    or
  • Add entry to Firefox experimental features page if feature is not yet enabled in release

Features to document

WebRTC - Deprecate non-standard frameRateMean and frameRateStdDev stats - check through docs & BCD to reflect.

Related Gecko bugs

https://bugzilla.mozilla.org/show_bug.cgi?id=1367562

@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Nov 29, 2021
@hamishwillee hamishwillee self-assigned this Dec 6, 2021
@hamishwillee hamishwillee moved this from To do to In progress in Firefox Release Project Dec 6, 2021
@hamishwillee
Copy link
Collaborator

hamishwillee commented Dec 6, 2021

The webidl shows these 5 properties removed: droppedFrames, bitrateMean, bitrateStdDev, framerateMean, framerateStdDev.

I did a search on these and none are in mdn or bcd. I also looked in the associated classes like: RTCOutboundRtpStreamStats, RTCOutboundRtpStreamStats and the sub classes in the chain. This all needs to be looked at again?

I found https://groups.google.com/g/discuss-webrtc/c/pkAtJEF_unM which discusses the changes. This covers this bug, but also reports removal of bytesReceived on "remote-inbound-rtp" stats. This might mean we need to remove RTCInboundRtpStreamStats.bytesReceived and/or RTCIceCandidatePairStats.bytesReceived. Might not - checking.

@Rumyra Is it worth adding a release note for this - given there is no evidence of this stuff every having being supported?

@Rumyra
Copy link
Collaborator Author

Rumyra commented Dec 6, 2021

Yes I think it's worth a rel note just for brevity - but it looks as tho nothing else is needed 👍

@hamishwillee
Copy link
Collaborator

Thanks. I've done the release note but I'll hold off on dev-doc-complete and moving this to closed until Friday to give that team time to confirm nothing else needs to be done

@hamishwillee
Copy link
Collaborator

hamishwillee commented Dec 13, 2021

@Rumyra So they got back to me in https://bugzilla.mozilla.org/show_bug.cgi?id=1367562#c7. The relevant bit is:

As part of bug 1654112 I most certainly think we should add a relnote for developers on this huge update. Those "sampling of improvements" bugs might not need any mention in relnotes (or docs -- they're bug fixes rather than features).

In other words, this bug in itself is nothing much but is part of a much bigger story in https://bugzilla.mozilla.org/show_bug.cgi?id=1654112

But I can't tell from that bug report what is relevant, or whether this is important to the MDN docs release process. My guess is that it is irrelevant to the MDN docs, but very relevant to the product.

Do you fancy chasing the big picture on this? If it were me I'd ask against that "bigger story bug" for the engineering team to suggest a release note - because we can't access the scope of change.

@Rumyra
Copy link
Collaborator Author

Rumyra commented Dec 15, 2021

But I can't tell from that bug report what is relevant, or whether this is important to the MDN docs release process. My guess is that it is irrelevant to the MDN docs, but very relevant to the product.

In a word yes...

By the looks of the main bug is part of a big update to the webRTC backend rather than any changes to the implementation of the spec (apart from above) - in which case this is the FF engineers domain for release notes under Firefox itself and not MDN.

I'll keep my eye on the original bug above as someone replied yesterday, but I don't think there's anymore to do from our end on this 👍

@hamishwillee
Copy link
Collaborator

Great. Moving to done and closing then (also set dev-doc-complete)

@hamishwillee hamishwillee moved this from In progress to Done in Firefox Release Project Dec 16, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2022
@bsmth bsmth added fx release archive A closed issue relating to firefox release notes for developers. and removed Firefox 96 labels Dec 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:WebAPI Web API docs fx release archive A closed issue relating to firefox release notes for developers. needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.
Projects
No open projects
Development

No branches or pull requests

3 participants