Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename createImageBitMaps's imageOrientation from "none" to "from-image" #23564

Open
yiyix opened this issue Jan 11, 2023 · 2 comments
Open

Rename createImageBitMaps's imageOrientation from "none" to "from-image" #23564

yiyix opened this issue Jan 11, 2023 · 2 comments
Labels
Content:WebAPI Web API docs waiting for implementations Waiting for feature to be implemented in browsers

Comments

@yiyix
Copy link

yiyix commented Jan 11, 2023

MDN URL

https://developer.mozilla.org/en-US/docs/Web/API/createImageBitmap

What specific section or headline is this issue about?

parameters

What information was incorrect, unhelpful, or incomplete?

imageOrientation
Specifies whether the image should be presented as is or flipped vertically. Either none (default) or flipY.

We are renaming the option "none" to "from-image".

What did you expect to see?

imageOrientation
Specifies whether the image should be presented as is or flipped vertically. Either from-image (default) or flipY.

Do you have any supporting links, references, or citations?

No response

Do you have anything more you want to share?

No response

@yiyix yiyix added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jan 11, 2023
@github-actions github-actions bot added the Content:WebAPI Web API docs label Jan 11, 2023
@sideshowbarker sideshowbarker added waiting for implementations Waiting for feature to be implemented in browsers and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Jan 12, 2023
@sideshowbarker
Copy link
Collaborator

@yiyix

We are renaming the option "none" to "from-image".

By that you mean it’s being renamed in the spec? And in implementations? If so, is there a HTML spec PR for it?

@sideshowbarker sideshowbarker added the needs info Needs more information to review or act on. label Jan 12, 2023
@yiyix
Copy link
Author

yiyix commented Jan 12, 2023

Yes, I mean we have created a PR to change the spec and a cl to change the current implementation:
spec change: whatwg/html#8710
Implementation: https://chromium-review.googlesource.com/c/chromium/src/+/4152576

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs waiting for implementations Waiting for feature to be implemented in browsers
Projects
None yet
Development

No branches or pull requests

2 participants