Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configuration type "transmission" should be replaced with "webrtc" #25223

Closed
opusonline opened this issue Mar 10, 2023 · 9 comments · Fixed by #25230
Closed

configuration type "transmission" should be replaced with "webrtc" #25223

opusonline opened this issue Mar 10, 2023 · 9 comments · Fixed by #25230
Labels
Content:WebAPI Web API docs needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.

Comments

@opusonline
Copy link

MDN URL

https://developer.mozilla.org/en-US/docs/Web/API/MediaCapabilities/encodingInfo

What specific section or headline is this issue about?

Parameter type "transmission" of configuration object should be replaced

What information was incorrect, unhelpful, or incomplete?

The value "transmission" of parameter "type" of configuration object should be replaced with "webrtc".

What did you expect to see?

The value "transmission" should be "webrtc".

Do you have any supporting links, references, or citations?

This is what the spec is saying: https://w3c.github.io/media-capabilities/#mediaencodingtype

Do you have anything more you want to share?

No response

MDN metadata

Page report details
@opusonline opusonline added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Mar 10, 2023
@github-actions github-actions bot added the Content:WebAPI Web API docs label Mar 10, 2023
@teoli2003
Copy link
Member

Thanks, good catch!

I opened a PR to get this fixed. When it is merged, this issue will be automatically closed. Please take a look at it and leave comments.

@opusonline
Copy link
Author

Hello. Thanks for your feedback!

I have noticed, that Firefox throws an Error when type "webrtc" is used:

TypeError: MediaCapabilities.encodingInfo: 'webrtc' (value of 'type' member of MediaEncodingConfiguration) is not a valid value for enumeration MediaEncodingType.

It will only work in Firefox with type "transmission".

Tested with Firefox version 110.0.1.

@teoli2003
Copy link
Member

I'm updating the docs with this extra info.

@teoli2003
Copy link
Member

Can you confirm that transmission is not working on Chrome?

@opusonline
Copy link
Author

opusonline commented Mar 10, 2023

Chrome 111.0.5563.64 throws the following Error:

TypeError: Failed to execute 'encodingInfo' on 'MediaCapabilities': Failed to read the 'type' property from 'MediaEncodingConfiguration': The provided value 'transmission' is not a valid enum value of type MediaEncodingType.

Even back until Chrome 101.0.4951.41, this Error is shown.

@opusonline
Copy link
Author

opusonline commented Mar 10, 2023

Also Safari (15.6.1 and 16.1) is throwing a TypeError with message "Type error" when encodingInfo() is called with type transmission.

@teoli2003
Copy link
Member

Thank you, so the new wording in #25230 is correct.

@opusonline
Copy link
Author

This looks good to me, thank you for taking care!

I've noticed a little typo at the type webrtc description:

uses transmission instad.

instad is missing an "e", so it should be instead.

Best regards!

@teoli2003
Copy link
Member

teoli2003 commented Mar 13, 2023

Thank you! Feel free to suggest (with the GitHub UI) changes in PRs; that way, you get credited.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:WebAPI Web API docs needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants