Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test your skills: Advanced HTML text — Task 2, paragraph 2: Copy discrepancy #641

Closed
fredhartley opened this issue Apr 17, 2023 · 19 comments
Labels
effort: small This task is a small effort. good first issue A good issue for newcomers to get started with.

Comments

@fredhartley
Copy link

MDN URL

https://developer.mozilla.org/en-US/docs/Learn/HTML/Introduction_to_HTML/Test_your_skills:_Advanced_HTML_text

What specific section or headline is this issue about?

Task 2

What information was incorrect, unhelpful, or incomplete?

There is a copy discrepancy between the finished examples and the live code in paragraph 2, task 2.

Finished example copy: "HTML, Hypertext Markup Language is by default accessible, if used correctly."
Default live code: "By default, HTML is accessible, if used correctly."

What did you expect to see?

The same copy between the finished example copy and the default life code. I.e. both "HTML, Hypertext Markup Language is by default accessible, if used correctly."

Do you have any supporting links, references, or citations?

No response

Do you have anything more you want to share?

No response

MDN metadata

Page report details
@fredhartley fredhartley added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Apr 17, 2023
@dostonnabotov
Copy link

Hi, there! 👋 I would be happy to pick it and fix this issue.

@mikoMK
Copy link
Contributor

mikoMK commented Apr 20, 2023

The same applies to the next line about CSS.

We should also remove "providing expansions as tooltips" from the task description, because the acronyms are written out as recommended and don't need a title attribute.

@advitiya7
Copy link

hello @fredhartley can you please assign this issue to me?
thanks

@fredhartley
Copy link
Author

@advitiya7 Warning — pretty new to GitHub. Maybe you can help. There is no settings cog besides 'Assignees' to assign you. Is this something I can do with my permissions?

@mikoMK
Copy link
Contributor

mikoMK commented Apr 29, 2023

As far as I know only maintainers can assign someone. I think it's okay if you just start working on this @advitiya7.
Make sure to mention the issue ID in your PR so they get linked. https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue

@postmeback
Copy link
Contributor

Any update on this ?

@mikoMK
Copy link
Contributor

mikoMK commented May 29, 2023

A month passed since the last update and it seems no one is working on it.
@dostonnabotov and @advitiya7: Is it okay if someone else takes over?

@advitiya7
Copy link

I'm sorry i completely forgot about this i shall do it by 9:30 IST if that is okay with you?

@mikoMK
Copy link
Contributor

mikoMK commented May 29, 2023

No reason to be sorry. I just wanted to make sure that there aren't two people working on it at the same time.

@advitiya7
Copy link

@mikoMK can you please tell me the location of the html code? the link given above does not have the code

@mikoMK
Copy link
Contributor

mikoMK commented May 29, 2023

@advitiya7
Copy link

thanks i wanted the link of learning area

@advitiya7
Copy link

@mikoMK i have made the changes to the repo learning-area please check

@postmeback
Copy link
Contributor

Hey @advitiya7 , can you please paste the PR links here ?

@advitiya7
Copy link

advitiya7 commented May 31, 2023

@postmeback #626

@bsmth
Copy link
Member

bsmth commented Jun 22, 2023

Hi @advitiya7 - we've edited in the wrong place, it would be great if you could make changes in the following file:

https://github.com/mdn/learning-area/blob/main/html/introduction-to-html/tasks/advanced-text/advanced-text2.html

instead of the "finished" example.

@bsmth bsmth removed the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jun 22, 2023
@bsmth bsmth transferred this issue from mdn/content Jun 22, 2023
@bsmth bsmth added good first issue A good issue for newcomers to get started with. effort: small This task is a small effort. labels Jun 22, 2023
@letsbecometechie
Copy link
Contributor

Hi @mikoMK / @bsmth, is this still open?
If yes can you please assign it to me? Happy to take it up

letsbecometechie added a commit to letsbecometechie/learning-area that referenced this issue Aug 3, 2023
… 2, paragraph 2: Copy discrepancy

In Task 2, Paragraph tag 2 is not similar between the Starter code and End code. Fixed the issue.
letsbecometechie added a commit to letsbecometechie/learning-area that referenced this issue Aug 3, 2023
…aph 2: Copy discrepancy mdn#641

Corrected the download file has well.
@vanshdhar999
Copy link

Is this issue still open?

bsmth added a commit that referenced this issue Aug 7, 2023
Fix for Issue -  Test your skills: Advanced HTML text — Task 2, paragraph 2: Copy discrepancy #641
@bsmth
Copy link
Member

bsmth commented Aug 7, 2023

This is now fixed by @letsbecometechie in #654

Thanks, all!

@bsmth bsmth closed this as completed Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: small This task is a small effort. good first issue A good issue for newcomers to get started with.
Projects
None yet
Development

No branches or pull requests

8 participants