Skip to content
This repository has been archived by the owner on Aug 26, 2022. It is now read-only.

T - some in-product Firefox links don't redirect to English (en-US) page if localized version doesn't exist #7209

Closed
Archaeopteryx opened this issue Jun 7, 2020 · 6 comments
Assignees
Labels
p2 Medium Priority: One of the next sprints Task type: bug report Type: Bugs, Defects, General Brokenness type: task

Comments

@Archaeopteryx
Copy link

Summary
some in-product Firefox links don't redirect to English (en-US) page if localized version doesn't exist

Steps To Reproduce (STR)
How can we reproduce the problem?

  1. Get a localized Firefox Nightly (79.0a1) or Beta (78.0b3). Reproduced this with German (de) and French (fr).
  2. Open https://www.mozilla.org
  3. Press Shift + F9 to open the web storage inspector.
  4. In the left sidebar, click onto a category, e.g. 'Indexed DB'.
  5. In the main pane, a text with a link will be shown. Click the linl.

Actual behavior
https://developer.mozilla.org/Tools/Storage_Inspector/IndexedDB gets opened but MDN claims the page doesn't exist.

Expected behavior
English content opened: https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector/IndexedDB

Additional context
This works e.g. for HTTP headers (tested with German):

  1. Press Ctrl+Shift+E to open the net monitor.
  2. Load a page, e.g. https://www.mozilla.org/de/
  3. Click onto the initial request.
  4. In the right sidebar, go to the line with "x-xss-protection".
  5. Click the button with the question mark.
    Actual & expected result: https://developer.mozilla.org/de/docs/Web/HTTP/Headers/X-XSS-Protection?utm_source=mozilla&utm_medium=devtools-netmonitor&utm_campaign=default opened with English content (see dropdown with available languages at the top right - it's a fallback and not a German page with the English content manually pasted).

Does the fallback only work e.g. for /Web/ pages?

@Archaeopteryx Archaeopteryx added the status: needs triage Status: Untriaged label Jun 7, 2020
@peterbe
Copy link
Contributor

peterbe commented Jun 8, 2020

You can reproduce this with this command:

curl -I -H "accept-language:de" https://developer.mozilla.org/Tools/Storage_Inspector/IndexedDB

Somewhere in kuma it says "This user wants German" but it never checks if that page has been translated so it's not using the usual fallback functionality that kicks in if you go to https://developer.mozilla.org/de/docs/Tools/Storage_Inspector/IndexedDB
However, that page is a bit messed up in that the HTTP exit code is actually 404 but it proceeds to display the en-US document (with a German chrome).

I think the solution should be; if you have a Accept-Language header that leads to a failed docment lookup-by-locale, it should do a redirect to the fallback if the URL doesn't have the /$locale/docs/ prefix. That's going to be something we need to care for and solve in Yari too.

@atopal
Copy link
Contributor

atopal commented Jun 8, 2020

Dev tools should link to a URL that has /docs in it

@tobinmori tobinmori added p2 Medium Priority: One of the next sprints and removed status: needs triage Status: Untriaged labels Jun 8, 2020
@tobinmori
Copy link

tobinmori commented Jun 8, 2020

action: notify FF devtools to update link

@atopal do you know who to contact for this?

@chinikes chinikes added type: bug report Type: Bugs, Defects, General Brokenness Task type: task labels Jun 17, 2020
@chinikes chinikes changed the title some in-product Firefox links don't redirect to English (en-US) page if localized version doesn't exist T - some in-product Firefox links don't redirect to English (en-US) page if localized version doesn't exist Jun 17, 2020
@chinikes chinikes added this to the Juliette (S6 Q2 2020) milestone Jun 19, 2020
@atopal
Copy link
Contributor

atopal commented Jul 29, 2020

I filed an issue for this in the devtools repo: firefox-devtools/devtools-core#1206

@atopal atopal closed this as completed Jul 29, 2020
@nchevobbe
Copy link

filed https://bugzilla.mozilla.org/show_bug.cgi?id=1655957 for the storage inspector

@juliandescottes
Copy link

This was fixed in https://bugzilla.mozilla.org/show_bug.cgi?id=1646945 and was uplifted all the way up to FF78

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p2 Medium Priority: One of the next sprints Task type: bug report Type: Bugs, Defects, General Brokenness type: task
Projects
None yet
Development

No branches or pull requests

7 participants