oojs/assessment: Shape constructor should take arguments

[bergus]

See http://stackoverflow.com/questions/43785607/inheritance-of-properties-through-passing-constructor-parameters
In general it is a good practise not to perform side effects (random) in constructors, but let the caller who creates the object do this.

[chrisdavidmills]

Argh, dammnit - my brain was out to lunch when I wrote this one ;-|

So, I have updated the call() description in this article:

https://developer.mozilla.org/en-US/docs/Learn/JavaScript/Objects/Inheritance#Defining_a_Teacher()_constructor_function

So that it hopefully makes more sense as to what it is doing.

I have also updated the description of the bouncing balls in the assessment:

https://developer.mozilla.org/en-US/docs/Learn/JavaScript/Objects/Adding_bouncing_balls_features

And updated the code examples:

https://github.com/mdn/learning-area/blob/master/javascript/oojs/assessment/main.js
https://github.com/mdn/learning-area/blob/master/javascript/oojs/advanced/oojs-class-inheritance-finished.html
https://github.com/mdn/learning-area/blob/master/javascript/oojs/advanced/oojs-class-inheritance-student.html

So I've kinda gone the opposite way here - removing the need for arguments altogether. I still think this is useful to show how a constructor can create an entire object with just a single line of code, even if the attributes are random rather than user defined.

I guess the best practice would be to have the values taken from the parameters rather than being just random, so the caller could decide to create an object of fixed or random size?

[chrisdavidmills]

I've updated the examples and text again, to take the random calls out of the constructor and into the instantiation calls.

[bergus]

Thanks for the quick response!
122ba2d fixes the issue.