Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[step-sequencer] The slider input to set the DTMF rate is not working as expected #118

Closed
ManuLintz opened this issue Dec 12, 2023 · 3 comments · Fixed by #122
Closed

[step-sequencer] The slider input to set the DTMF rate is not working as expected #118

ManuLintz opened this issue Dec 12, 2023 · 3 comments · Fixed by #122

Comments

@ManuLintz
Copy link

What information was incorrect, unhelpful, or incomplete?

This input doesn't behave as it should:
image

What did you expect to see?

When setting the slider like this, we don't hear anything anymore (here):
image

The problem comes from that the value is cast into an int in the event listener callback (also happens in #117).

rateControl.addEventListener(
  "input",
  (ev) => {
    playbackRate = parseInt(ev.target.value, 10);
  },
  false
);

It was written to have a 0.1 step:

<section class="controls">
  <label for="rate">Rate</label>
  <input
    name="rate"
    id="rate"
    type="range"
    min="0.1"
    max="2"
    value="1"
    step="0.1"
  />
</section>

Since I identified what causes the issue in the code I'd be happy to work on a fix + updating the doc.

Do you have any supporting links, references, or citations?

No response

Do you have anything more you want to share?

No response

@ManuLintz ManuLintz added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Dec 12, 2023
@bsmth bsmth removed the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jan 25, 2024
@bsmth
Copy link
Member

bsmth commented Jan 25, 2024

Thanks a lot for reporting it! There's a PR open which should fix this

Since I identified what causes the issue in the code I'd be happy to work on a fix + updating the doc.

Sorry I missed this, would you like to update the doc after this is merged?

@ManuLintz
Copy link
Author

Yes sure, I'd love to

@bsmth
Copy link
Member

bsmth commented Jan 25, 2024

Great, feel free to ping me on the PR when you get around to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants