Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples disabled when run via web-ext or from folder (applyCSS, borderify) #556

Closed
dhowe opened this issue Mar 21, 2024 · 9 comments
Closed
Labels
needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.

Comments

@dhowe
Copy link

dhowe commented Mar 21, 2024

What information was incorrect, unhelpful, or incomplete?

Extensions (borderify, applyCss) load but addons are grayed out in menu. There is no page action visible for applyCss

What did you expect to see?

Expected the examples to work after following instructions.

The examples site reads "Warning: Some examples work only on specific domains or pages. Details of any restrictions are provided in each example's readme file.", yet there are NO restrictions mentioned in the applyCss or borderify READMEs, even though borderify appears only to work on mozilla.org

applyCss appears to have no host permissions, so not sure how it would work anyhow (thus the 'Can't read and change data on this site' message), while borderify has only mozilla.org

Do you have anything more you want to share?

FF 124.0 (64-bit)
OSX 11.7.9

@dhowe dhowe added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Mar 21, 2024
Copy link

It looks like this is your first issue. Welcome! 👋 One of the project maintainers will be with you as soon as possible. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct.

@rebloor
Copy link
Collaborator

rebloor commented Mar 21, 2024

@dhowe This isn't unexpected. "Can't read and change data on this site", means that the extension doesn't have "host" (or site) permission, which would be needed to inject scripts into the site or manipulate requests to the server.

If you locate the page action, you can see the extension works:
image

@rebloor rebloor closed this as completed Mar 21, 2024
@dhowe
Copy link
Author

dhowe commented Mar 22, 2024

The problem is not that specific message, but the fact that the addon is grayed-out, and has no pin option, so one cannot access the page-action, and thus cannot run the example. It is also the case for the 'borderify' example, even on mozilla.org for which it has permissions.

The examples site reads "Warning: Some examples work only on specific domains or pages. Details of any restrictions are provided in each example's readme file.", yet there is NO restriction mentioned in the applyCss or borderify READMEs, even though borderify appears as if it would only work on mozilla.org

image

@dhowe dhowe changed the title "can't read and change data on this site" testing applyCSS "Can't read and change data on this site", examples grayed out (applyCSS, borderify) Mar 22, 2024
@rebloor
Copy link
Collaborator

rebloor commented Mar 22, 2024

If you look at the screenshot I added earlier the "page action" is the red circle icon in the address bar.

@dhowe
Copy link
Author

dhowe commented Mar 22, 2024

Again, there is no page action as it is disabled/grayed-out. I've updated the title to better reflect the issue

image

@dhowe dhowe changed the title "Can't read and change data on this site", examples grayed out (applyCSS, borderify) Examples disabled when run via web-ext (applyCSS, borderify) Mar 22, 2024
@dhowe dhowe changed the title Examples disabled when run via web-ext (applyCSS, borderify) Examples disabled when run via web-ext or from folder (applyCSS, borderify) Mar 22, 2024
@rebloor
Copy link
Collaborator

rebloor commented Mar 22, 2024

@dhowe the two extensions are grayed in the add-ons list because they don't have a browser action and therefore no toolbar button to "pin".
In the example screenshot in your last message you can see that borderify is working because there is a red border around the mozilla.org page.
What you will find is that you cannot used borderify and apply-css together - remove borderify, reload the page and the click the red circle icon in the address bar. It will apply a wider red margin to the page. (And if you open the extension setting you can also find options to allow it to work in private pages and the restricted pages.)

@dhowe
Copy link
Author

dhowe commented Mar 22, 2024

You're correct -- borderify seems to be working, though applyCss I still don't see any button in the address bar:

image

@rebloor
Copy link
Collaborator

rebloor commented Mar 22, 2024

@dhowe in dark mode it appears to be a white circle
image

@dhowe
Copy link
Author

dhowe commented Mar 22, 2024

Got it, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.
Projects
None yet
Development

No branches or pull requests

2 participants